Rename raw_image() to image_bytes() in UserImage

components/user_manager/user_image/user_image.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_USER_MANAGER_USER_IMAGE_USER_IMAGE_H_
 #define COMPONENTS_USER_MANAGER_USER_IMAGE_USER_IMAGE_H_
 
 #include <string>
 #include <vector>
 
 #include "base/files/file_path.h"
 #include "components/user_manager/user_manager_export.h"
 #include "ui/gfx/image/image_skia.h"
 #include "url/gurl.h"
 
 namespace user_manager {
 
-// Wrapper class storing a still image and it's raw representation.  Could be
-// used for storing profile images and user wallpapers.
+// Wrapper class storing a still image and it's web representation in a

[hashimoto, 2016/02/29 08:01:59]

s/it's/its/?

[satorux1, 2016/02/29 08:11:41]

Done.

+// web-compatible format such as JPEG. Could be used for storing profile
+// images and user wallpapers.
 class USER_MANAGER_EXPORT UserImage {
  public:
+  // Used to store data bytes of web representation.
   // TODO(ivankr): replace with RefCountedMemory to prevent copying.
-  typedef std::vector<unsigned char> RawImage;
+  typedef std::vector<unsigned char> WebImage;

[hashimoto, 2016/02/29 08:01:59]

I'm not sure if WebImage is better than RawImage.
RawImage is "raw" because the skia image is created by reading it.
The new name "WebImage" tells nothing about the relationship between them.

Also, the name "WebImage" implies it provides methods to get information about
the image (e.g. size, color depth), while it's actually just a blob data.

[satorux1, 2016/02/29 08:11:41]

It's not always the case. RawImage is generated from the skia image if UserImage
is created with CreateAndEncode().
How about removing the typedef?

[hashimoto, 2016/02/29 10:03:19]

Removing typedef doesn't sound like a good thing to do.
How about something as boring as "EncodedBytes" or "CompressedImageData"?
"WebImage" sounds fancy, but it's not obvious what it actually means.

[satorux1, 2016/02/29 11:07:49]

How about just Bytes? This might sound too generic, but it's inside of a class
in a namespace, so the client code will look like user_manager::UserImage::Bytes

[hashimoto, 2016/03/01 05:59:10]

Bytes as a type name sounds sufficiently boring too me.
Please don't forget to give methods and variables boring but informative names
too.

[satorux1, 2016/03/01 07:37:04]

Done!

 
-  // Creates a new instance from a given still frame and tries to encode raw
-  // representation for it.
+  // Creates a new instance from a given still frame and tries to encode it
+  // to web representation.
   // TODO(ivankr): remove eventually.
   static UserImage CreateAndEncode(const gfx::ImageSkia& image);
 
-  // Create instance with an empty still frame and no raw data.
+  // Create instance with an empty still frame and no web representation.
   UserImage();
 
-  // Creates a new instance from a given still frame without any raw data.
+  // Creates a new instance from a given still frame without any web
+  // representation.
   explicit UserImage(const gfx::ImageSkia& image);
 
-  // Creates a new instance from a given still frame and raw representation.
-  UserImage(const gfx::ImageSkia& image, const RawImage& raw_image);
+  // Creates a new instance from a given still frame and web representation.
+  UserImage(const gfx::ImageSkia& image, const WebImage& web_image);
 
   virtual ~UserImage();
 
   const gfx::ImageSkia& image() const { return image_; }
 
-  // Optional raw representation of the still image.
-  bool has_raw_image() const { return has_raw_image_; }
-  const RawImage& raw_image() const { return raw_image_; }
+  // Optional web representation of the still image.
+  bool has_web_image() const { return has_web_image_; }
+  const WebImage& web_image() const { return web_image_; }
 
-  // Discards the stored raw image, freeing used memory.
-  void DiscardRawImage();
+  // Discards the stored web image, freeing used memory.
+  void DiscardWebImage();
 
   // URL from which this image was originally downloaded, if any.
   void set_url(const GURL& url) { url_ = url; }
   GURL url() const { return url_; }
 
-  // Whether |raw_image| contains data in format that is considered safe to
+  // Whether |web_image| contains data in format that is considered safe to
   // decode in sensitive environment (on Login screen).
   bool is_safe_format() const { return is_safe_format_; }
   void MarkAsSafe();
 
   const base::FilePath& file_path() const { return file_path_; }
   void set_file_path(const base::FilePath& file_path) {
     file_path_ = file_path;
   }
 
  private:
   gfx::ImageSkia image_;
-  bool has_raw_image_;
-  RawImage raw_image_;
+  bool has_web_image_;
+  WebImage web_image_;
   GURL url_;
 
   // If image was loaded from the local file, file path is stored here.
   base::FilePath file_path_;
   bool is_safe_format_;
 };
 
 }  // namespace user_manager
 
 #endif  // COMPONENTS_USER_MANAGER_USER_IMAGE_USER_IMAGE_H_