chrome/browser/ui/views/tabs/tab_drag_controller.cc - Issue 1747803003: MacViews: Implement Tab Dragging

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/tabs/tab_drag_controller.cc

Issue 1747803003: MacViews: Implement Tab Dragging (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Extract CocoaWindowMoveLoop, fix review issues. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/tabs/tab_drag_controller.cc

diff --git a/chrome/browser/ui/views/tabs/tab_drag_controller.cc b/chrome/browser/ui/views/tabs/tab_drag_controller.cc

index 5c5160367fccd04fa56076e1a5c9f61f7242fba8..125923101c96e8957603a747898599193143280d 100644

--- a/chrome/browser/ui/views/tabs/tab_drag_controller.cc

+++ b/chrome/browser/ui/views/tabs/tab_drag_controller.cc

@@ -382,7 +382,7 @@ void TabDragController::Drag(const gfx::Point& point_in_screen) {

&drag_bounds);

widget->SetVisibilityChangedAnimationsEnabled(true);

}

- RunMoveLoop(GetWindowOffset(point_in_screen));

+ RunMoveLoop(GetWindowOffset(start_point_in_screen_));

return;

}