Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1747593002: Change the type for byte counts to size_t in WebMediaPlayer (Closed)

Created:
4 years, 9 months ago by chakshu
Modified:
4 years, 9 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, philipj_slow, posciak+watch_chromium.org, avayvod+watch_chromium.org, blink-reviews-html_chromium.org, jam, mcasas+watch_chromium.org, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, blink-reviews, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-blink_chromium.org, blink-reviews-api_chromium.org, mlamouri+watch-media_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change the type for byte counts to size_t in WebMediaPlayer BUG=234995 Committed: https://crrev.com/94326b75fc5b320ff478e82023c1c4296a83750e Cr-Commit-Position: refs/heads/master@{#379754}

Patch Set 1 #

Patch Set 2 : Made changes in the unittests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M content/renderer/media/android/webmediaplayer_android.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/html_video_element_capturer_source_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/blink/webmediaplayer_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLVideoElementTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/platform/WebMediaPlayer.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 24 (13 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1747593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1747593002/1
4 years, 9 months ago (2016-02-29 06:00:51 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/122785)
4 years, 9 months ago (2016-02-29 06:15:00 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1747593002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1747593002/20001
4 years, 9 months ago (2016-02-29 09:14:14 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-02-29 10:34:06 UTC) #8
palmer
lgtm
4 years, 9 months ago (2016-03-03 00:34:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1747593002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1747593002/20001
4 years, 9 months ago (2016-03-03 05:38:18 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/152843)
4 years, 9 months ago (2016-03-03 05:54:03 UTC) #15
cpu_(ooo_6.6-7.5)
lgtm
4 years, 9 months ago (2016-03-07 18:28:08 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1747593002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1747593002/20001
4 years, 9 months ago (2016-03-08 03:34:45 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-08 05:11:52 UTC) #22
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 05:13:02 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/94326b75fc5b320ff478e82023c1c4296a83750e
Cr-Commit-Position: refs/heads/master@{#379754}

Powered by Google App Engine
This is Rietveld 408576698