content/renderer/media/android/webmediaplayer_android.cc - Issue 1747593002: Change the type for byte counts to size_t in WebMediaPlayer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/android/webmediaplayer_android.cc

Issue 1747593002: Change the type for byte counts to size_t in WebMediaPlayer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Made changes in the unittests Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/android/webmediaplayer_android.h ('k') | content/renderer/media/html_video_element_capturer_source_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/android/webmediaplayer_android.cc

diff --git a/content/renderer/media/android/webmediaplayer_android.cc b/content/renderer/media/android/webmediaplayer_android.cc

index 8616d130ecd3bc34babc7abfb46d8b07e9def461..48f31fd86020b7598b4a78b7807e63821dfaf115 100644

--- a/content/renderer/media/android/webmediaplayer_android.cc

+++ b/content/renderer/media/android/webmediaplayer_android.cc

@@ -786,14 +786,14 @@ unsigned WebMediaPlayerAndroid::droppedFrameCount() const {

return 0;

}

-unsigned WebMediaPlayerAndroid::audioDecodedByteCount() const {

+size_t WebMediaPlayerAndroid::audioDecodedByteCount() const {

if (media_source_delegate_)

return media_source_delegate_->AudioDecodedByteCount();

NOTIMPLEMENTED();

return 0;

}

-unsigned WebMediaPlayerAndroid::videoDecodedByteCount() const {

+size_t WebMediaPlayerAndroid::videoDecodedByteCount() const {

if (media_source_delegate_)

return media_source_delegate_->VideoDecodedByteCount();

NOTIMPLEMENTED();