Issue 1747003003: [Smart Lock, UI] Use correct string for the auto sign-in first run.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1747003003: [Smart Lock, UI] Use correct string for the auto sign-in first run. (Closed)

Created:
4 years, 9 months ago by melandory

Modified:
4 years, 9 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2661

Target Ref:
refs/pending/branch-heads/2661

Project:
chromium

Visibility:
Public.

[Smart Lock, UI] Use correct string for the auto sign-in first run. Method which check is settings are synced should check PRIORITY_PREFERENCE instead of PREFERENCE, because only they are synced on mobile devices. BUG=590756 Review URL: https://codereview.chromium.org/1750603002 Cr-Commit-Position: refs/heads/master@{#378238} (cherry picked from commit d2329b1a69b53d8f4384c60d0cd31cd03908cde3) Committed: https://chromium.googlesource.com/chromium/src/+/e793c79f11ef1f2a8ff3a884c9c6a627ee33333a

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -6 lines)			Patch
M	chrome/browser/password_manager/auto_signin_first_run_dialog_android.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/passwords/manage_passwords_view_utils.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/passwords/manage_passwords_view_utils.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/passwords/password_dialog_controller_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (1 generated)

melandory

4 years, 9 months ago (2016-02-29 23:54:59 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e793c79f11ef1f2a8ff3a884c9c6a627ee33333a.