Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 1750603002: [Smart Lock, UI] Use correct string for the auto sign-in first run. (Closed)

Created:
4 years, 9 months ago by melandory
Modified:
4 years, 9 months ago
Reviewers:
vasilii
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Smart Lock, UI] Use correct string for the auto sign-in first run. Method which check is settings are synced should check PRIORITY_PREFERENCE instead of PREFERENCE, because only they are synced on mobile devices. BUG=590756 Committed: https://crrev.com/d2329b1a69b53d8f4384c60d0cd31cd03908cde3 Cr-Commit-Position: refs/heads/master@{#378238}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M chrome/browser/password_manager/auto_signin_first_run_dialog_android.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_view_utils.h View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_view_utils.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/passwords/password_dialog_controller_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
melandory
PTAL, thanks!
4 years, 9 months ago (2016-02-29 16:24:13 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750603002/1
4 years, 9 months ago (2016-02-29 17:00:17 UTC) #5
vasilii
https://codereview.chromium.org/1750603002/diff/1/chrome/browser/ui/passwords/manage_passwords_view_utils.cc File chrome/browser/ui/passwords/manage_passwords_view_utils.cc (right): https://codereview.chromium.org/1750603002/diff/1/chrome/browser/ui/passwords/manage_passwords_view_utils.cc#newcode176 chrome/browser/ui/passwords/manage_passwords_view_utils.cc:176: bool IsSyncingSettings(Profile* profile) { Make the method name more ...
4 years, 9 months ago (2016-02-29 17:20:48 UTC) #6
melandory
https://codereview.chromium.org/1750603002/diff/1/chrome/browser/ui/passwords/manage_passwords_view_utils.cc File chrome/browser/ui/passwords/manage_passwords_view_utils.cc (right): https://codereview.chromium.org/1750603002/diff/1/chrome/browser/ui/passwords/manage_passwords_view_utils.cc#newcode176 chrome/browser/ui/passwords/manage_passwords_view_utils.cc:176: bool IsSyncingSettings(Profile* profile) { On 2016/02/29 17:20:48, vasilii wrote: ...
4 years, 9 months ago (2016-02-29 17:37:52 UTC) #7
vasilii
lgtm
4 years, 9 months ago (2016-02-29 17:42:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750603002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750603002/40001
4 years, 9 months ago (2016-02-29 17:50:04 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-02-29 18:34:49 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-02-29 18:36:51 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d2329b1a69b53d8f4384c60d0cd31cd03908cde3
Cr-Commit-Position: refs/heads/master@{#378238}

Powered by Google App Engine
This is Rietveld 408576698