chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java - Issue 1746933002: Check if asyncparams is null for document mode UI initialization

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java

Issue 1746933002: Check if asyncparams is null for document mode UI initialization (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java

index 345fa551efc348eea6998f2f930f790d5633c67b..d9285307dec9f8d2ca99704adbb1685b8ebeace9 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java

@@ -578,7 +578,7 @@ public class DocumentActivity extends ChromeActivity {

boolean isCreatedWithWebContents = asyncParams != null

&& asyncParams.getWebContents() != null;

- if (params.getTabToReparent() != null) {

+ if (params != null && params.getTabToReparent() != null) {

mTab = params.getTabToReparent();

mTab.reparentToActivity(this, new DocumentTabDelegateFactory());

} else {

« no previous file with comments | « no previous file | no next file » | no next file with comments »