Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1746743002: Use checked-in .package file for building and testing (Closed)

Created:
4 years, 9 months ago by Bill Hesse
Modified:
4 years, 3 months ago
Reviewers:
Bob Nystrom, kustermann
CC:
reviews_dartlang.org, Harry Terkelsen, Siggi Cherem (dart-lang), Johnni Winther
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use checked-in .package file for building and testing Stop creating [build dir]/packages directory with symbolic links. BUG=https://github.com/dart-lang/sdk/issues/23565 R=rnystrom@google.com Committed: https://github.com/dart-lang/sdk/commit/5d3e356ca75be8aeff3efde5df946d746b9f8352 Reverted: https://github.com/dart-lang/sdk/commit/6d238ba197c8bda71afe790f16f6e9adaf7abd13 Committed: https://github.com/dart-lang/sdk/commit/61eee9ee523c27a9a75945c76eb9c7837549912c

Patch Set 1 #

Patch Set 2 : Finish changes.. #

Patch Set 3 : Stop creating [build_dir]/packages #

Total comments: 2

Patch Set 4 : Remove old packages dir and old .packages file. #

Patch Set 5 : Fix more build and test failures. #

Patch Set 6 : Add dart2js changes #

Patch Set 7 : Update vm/cc status. #

Patch Set 8 : Status fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+262 lines, -252 lines) Patch
M .gitignore View 1 1 chunk +0 lines, -1 line 0 comments Download
A .packages View 1 2 1 chunk +103 lines, -0 lines 0 comments Download
M pkg/pkg.gyp View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/pkg.status View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/dart-runtime.gyp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/observatory.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/tests/vm/vm.status View 1 2 3 4 5 6 1 chunk +3 lines, -0 lines 0 comments Download
M sdk/bin/dart2js View 1 1 chunk +1 line, -38 lines 0 comments Download
M sdk/bin/dart2js.bat View 1 2 1 chunk +1 line, -8 lines 0 comments Download
M sdk/bin/dartanalyzer View 1 1 chunk +1 line, -39 lines 0 comments Download
M sdk/bin/dartanalyzer.bat View 1 2 1 chunk +1 line, -8 lines 0 comments Download
M sdk/bin/dartdevc View 1 2 1 chunk +1 line, -39 lines 0 comments Download
M sdk/bin/dartdevc.bat View 1 2 1 chunk +1 line, -8 lines 0 comments Download
M sdk/bin/dartfmt View 1 2 1 chunk +1 line, -14 lines 0 comments Download
M sdk/bin/dartfmt.bat View 1 2 1 chunk +1 line, -8 lines 0 comments Download
M sdk/bin/pub View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M sdk/bin/pub.bat View 1 2 1 chunk +1 line, -2 lines 0 comments Download
A sdk/lib/_internal/js_runtime/.packages View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/analyze_helper.dart View 1 2 3 4 5 2 chunks +2 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/dart2js_resolver_test.dart View 1 2 3 4 5 1 chunk +2 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/memory_compiler.dart View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M tests/standalone/io/addlatexhash_test.dart View 1 2 3 4 3 chunks +16 lines, -6 lines 0 comments Download
M tests/standalone/io/code_collection_test.dart View 1 2 3 4 1 chunk +12 lines, -3 lines 0 comments Download
M tests/standalone/io/http_client_stays_alive_test.dart View 1 2 chunks +12 lines, -4 lines 0 comments Download
M tests/standalone/io/platform_test.dart View 1 2 3 4 2 chunks +7 lines, -6 lines 0 comments Download
M tests/standalone/io/test_runner_test.dart View 1 2 3 4 2 chunks +13 lines, -1 line 0 comments Download
M tests/standalone/standalone.status View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M tools/bots/dart_sdk.py View 1 2 3 4 1 chunk +1 line, -4 lines 0 comments Download
M tools/make_links.py View 1 2 3 5 chunks +34 lines, -11 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 1 2 3 4 7 chunks +14 lines, -13 lines 0 comments Download
M utils/analysis_server/analysis_server.gyp View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M utils/compiler/compiler.gyp View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M utils/compiler/create_snapshot.dart View 1 2 4 chunks +5 lines, -9 lines 0 comments Download
M utils/dartanalyzer/dartanalyzer.gyp View 1 2 3 4 5 4 chunks +15 lines, -4 lines 0 comments Download
M utils/dartdevc/dartdevc.gyp View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M utils/dartdoc/dartdoc.gyp View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M utils/dartfmt/dartfmt.gyp View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M utils/pub/pub.gyp View 1 2 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Bill Hesse
Follow-up CLs will remove make_links.dart and the entire pkg.gyp file, and the pkg/BUILD.gn file. TODO: ...
4 years, 3 months ago (2016-09-14 14:30:12 UTC) #3
Bob Nystrom
LGTM, though I'm not very familiar with most of the stuff here. https://codereview.chromium.org/1746743002/diff/40001/tools/testing/dart/test_suite.dart File tools/testing/dart/test_suite.dart ...
4 years, 3 months ago (2016-09-14 23:56:09 UTC) #4
Bill Hesse
Committed patchset #4 (id:60001) manually as 5d3e356ca75be8aeff3efde5df946d746b9f8352 (presubmit successful).
4 years, 3 months ago (2016-09-15 12:50:38 UTC) #6
Bill Hesse
On 2016/09/15 12:50:38, Bill Hesse wrote: > Committed patchset #4 (id:60001) manually as > 5d3e356ca75be8aeff3efde5df946d746b9f8352 ...
4 years, 3 months ago (2016-09-15 16:52:10 UTC) #8
Bill Hesse
4 years, 3 months ago (2016-09-16 13:03:25 UTC) #10
Message was sent while issue was closed. 
Committed patchset #8 (id:140001) manually as
61eee9ee523c27a9a75945c76eb9c7837549912c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698