Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Unified Diff: utils/compiler/create_snapshot.dart

Issue 1746743002: Use checked-in .package file for building and testing (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Status fixes Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « utils/compiler/compiler.gyp ('k') | utils/dartanalyzer/dartanalyzer.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/compiler/create_snapshot.dart
diff --git a/utils/compiler/create_snapshot.dart b/utils/compiler/create_snapshot.dart
index 1a274310cb5909458e38be3809e2fce9dec9adf6..2b5b869c50a69622e66c2db9ca70b2d0ec988a43 100644
--- a/utils/compiler/create_snapshot.dart
+++ b/utils/compiler/create_snapshot.dart
@@ -61,10 +61,9 @@ void writeSnapshotFile(var path, var content) {
writer.close();
}
-Future createSnapshot(var dart_file, var packageRoot) {
+Future createSnapshot(var dart_file) {
return Process.run(Platform.executable,
- ["--package-root=$packageRoot",
- "--snapshot=$dart_file.snapshot",
+ ["--snapshot=$dart_file.snapshot",
dart_file])
.then((result) {
if (result.exitCode != 0) {
@@ -80,11 +79,9 @@ Future createSnapshot(var dart_file, var packageRoot) {
* Takes the following arguments:
* --output_dir=val The full path to the output_dir.
* --dart2js_main=val The path to the dart2js main script relative to root.
- * --package-root=val The package-root used to find packages for the snapshot.
*/
void main(List<String> arguments) {
- var validArguments = ["--output_dir", "--dart2js_main",
- "--package_root"];
+ var validArguments = ["--output_dir", "--dart2js_main"];
var args = {};
for (var argument in arguments) {
var argumentSplit = argument.split("=");
@@ -96,7 +93,6 @@ void main(List<String> arguments) {
}
if (!args.containsKey("dart2js_main")) throw "Please specify dart2js_main";
if (!args.containsKey("output_dir")) throw "Please specify output_dir";
- if (!args.containsKey("package_root")) throw "Please specify package_root";
var scriptFile = Uri.base.resolveUri(Platform.script);
var path = scriptFile.resolve(".");
@@ -104,13 +100,13 @@ void main(List<String> arguments) {
getSnapshotGenerationFile(args, rootPath).then((result) {
var wrapper = "${args['output_dir']}/utils_wrapper.dart";
writeSnapshotFile(wrapper, result);
- createSnapshot(wrapper, args["package_root"]);
+ createSnapshot(wrapper);
});
getDart2jsSnapshotGenerationFile(args, rootPath).then((result) {
var wrapper = "${args['output_dir']}/dart2js.dart";
writeSnapshotFile(wrapper, result);
- createSnapshot(wrapper, args["package_root"]);
+ createSnapshot(wrapper);
});
}
« no previous file with comments | « utils/compiler/compiler.gyp ('k') | utils/dartanalyzer/dartanalyzer.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698