content/shell/common/shell_messages.h - Issue 1746393002: Quit BlinkTestRunner::TestFinished early if main frame is not local.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/common/shell_messages.h

Issue 1746393002: Quit BlinkTestRunner::TestFinished early if main frame is not local. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@reenable-tests-fixed-by-alex

Patch Set: Rebasing... Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/browser/layout_test/notify_done_forwarder.cc ('k') | content/shell/renderer/layout_test/blink_test_runner.cc » ('j') | content/shell/renderer/layout_test/blink_test_runner.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/common/shell_messages.h

diff --git a/content/shell/common/shell_messages.h b/content/shell/common/shell_messages.h

index acbbfb019d2c9c4adee1bf88332a0a6700247b96..cbf1a3d2758000cc37c4c2cb8b5980ef40454dbc 100644

--- a/content/shell/common/shell_messages.h

+++ b/content/shell/common/shell_messages.h

@@ -50,8 +50,8 @@ IPC_MESSAGE_CONTROL1(ShellViewMsg_SetWebKitSourceDir,

IPC_MESSAGE_ROUTED1(ShellViewMsg_SetTestConfiguration,

content::ShellTestConfiguration)

-// Tells the main window that a secondary window in a different process invoked

-// notifyDone().

+// Tells the main window that a secondary renderer in a different process thinks

+// the test is finished.

IPC_MESSAGE_ROUTED0(ShellViewMsg_NotifyDone)

// Pushes a snapshot of the current session history from the browser process.

@@ -102,7 +102,7 @@ IPC_MESSAGE_ROUTED0(ShellViewHostMsg_TestFinished)

IPC_MESSAGE_ROUTED0(ShellViewHostMsg_ResetDone)

-IPC_MESSAGE_ROUTED0(ShellViewHostMsg_TestFinishedInSecondaryWindow)

+IPC_MESSAGE_ROUTED0(ShellViewHostMsg_TestFinishedInSecondaryRenderer)

// WebTestDelegate related.

IPC_MESSAGE_ROUTED1(ShellViewHostMsg_OverridePreferences,