Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: content/shell/renderer/layout_test/blink_test_runner.cc

Issue 1746393002: Quit BlinkTestRunner::TestFinished early if main frame is not local. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@reenable-tests-fixed-by-alex
Patch Set: Rebasing... Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/shell/common/shell_messages.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/renderer/layout_test/blink_test_runner.cc
diff --git a/content/shell/renderer/layout_test/blink_test_runner.cc b/content/shell/renderer/layout_test/blink_test_runner.cc
index 6bc6ad435fec5abb55b280447ed5f99b95955ae4..22648fe862f43acd3284fe379a5aadea8f4b4bb1 100644
--- a/content/shell/renderer/layout_test/blink_test_runner.cc
+++ b/content/shell/renderer/layout_test/blink_test_runner.cc
@@ -611,8 +611,8 @@ void BlinkTestRunner::SetLocale(const std::string& locale) {
}
void BlinkTestRunner::TestFinished() {
- if (!is_main_window_) {
- Send(new ShellViewHostMsg_TestFinishedInSecondaryWindow(routing_id()));
+ if (!is_main_window_ || !render_view()->GetMainRenderFrame()) {
jochen (gone - plz use gerrit) 2016/03/04 12:38:52 ah, so you consider all OOPIF of the main window t
Łukasz Anforowicz 2016/03/04 20:41:41 Correct, except to be precise s/OOPIF/RenderViews/
Łukasz Anforowicz 2016/03/04 20:51:19 i.e. only one of the BlinkTestRunner's will have |
+ Send(new ShellViewHostMsg_TestFinishedInSecondaryRenderer(routing_id()));
return;
}
test_runner::WebTestInterfaces* interfaces =
« no previous file with comments | « content/shell/common/shell_messages.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698