content/shell/browser/layout_test/notify_done_forwarder.h - Issue 1746393002: Quit BlinkTestRunner::TestFinished early if main frame is not local.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/layout_test/notify_done_forwarder.h

Issue 1746393002: Quit BlinkTestRunner::TestFinished early if main frame is not local. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@reenable-tests-fixed-by-alex

Patch Set: Rebasing... Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/browser/layout_test/blink_test_controller.cc ('k') | content/shell/browser/layout_test/notify_done_forwarder.cc » ('j') | content/shell/renderer/layout_test/blink_test_runner.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/browser/layout_test/notify_done_forwarder.h

diff --git a/content/shell/browser/layout_test/notify_done_forwarder.h b/content/shell/browser/layout_test/notify_done_forwarder.h

index fd1b0c1e0d01720f6878a3b50b5a05b2b04000d8..c512c2472f8605a2ae8bb90acf1d23b1f5acf1c0 100644

--- a/content/shell/browser/layout_test/notify_done_forwarder.h

+++ b/content/shell/browser/layout_test/notify_done_forwarder.h

@@ -24,7 +24,7 @@ class NotifyDoneForwarder : public WebContentsObserver,

explicit NotifyDoneForwarder(WebContents* web_contents);

- void OnTestFinishedInSecondaryWindow();

+ void OnTestFinishedInSecondaryRenderer();

DISALLOW_COPY_AND_ASSIGN(NotifyDoneForwarder);

};