Issue 1746263003: Clean up MojoShellConnection in render processes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1746263003: Clean up MojoShellConnection in render processes (Closed)

Created:
4 years, 9 months ago by Ken Rockot(use gerrit already)

Modified:
4 years, 9 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2664

Target Ref:
refs/pending/branch-heads/2664

Project:
chromium

Visibility:
Public.

Clean up MojoShellConnection in render processes MojoShellConnectionImpl ultimately owns a RunnerConnection, which in turn spins up a new thread. If we don't explicitly tear this down then we leak that thread. BUG=590472 R=ben@chromium.org TBR=ben@chromium.org Review URL: https://codereview.chromium.org/1748093002 . Cr-Commit-Position: refs/heads/master@{#378394} (cherry picked from commit 6cb09bb59dd7ed4dcd37e14c32586ea25490f896) Committed: https://chromium.googlesource.com/chromium/src/+/c5003b063fe4daffbc47fabd8573718ec53c4e73

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -8 lines)			Patch
M	content/renderer/renderer_main.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	mojo/shell/runner/host/child_process_host.cc	View	2 chunks	+13 lines, -7 lines	0 comments	Download
M	mojo/shell/runner/host/out_of_process_native_runner.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 2 (1 generated)

Ken Rockot(use gerrit already)

4 years, 9 months ago (2016-03-01 15:41:14 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c5003b063fe4daffbc47fabd8573718ec53c4e73.