Clean up MojoShellConnection in render processes

Clean up MojoShellConnection in render processes

MojoShellConnectionImpl ultimately owns a RunnerConnection, which in
turn spins up a new thread. If we don't explicitly tear this down then
we leak that thread.

BUG=590472
R=ben@chromium.org
TBR=ben@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/6cb09bb59dd7ed4dcd37e14c32586ea25490f896

[Ken Rockot(use gerrit already), 2016-02-29 21:43:24]

rockot@chromium.org changed reviewers:
+ ben@chromium.org

[Ken Rockot(use gerrit already), 2016-02-29 21:49:26]

Description was changed from

==========
Clean up MojoShellConnection in render processes

MojoShellConnectionImpl ultimately owns a RunnerConnection, which in
turn spins up a new thread. If we don't explicitly tear this down then
we leak that thread.

BUG=590472
==========

to

==========
Clean up MojoShellConnection in render processes

MojoShellConnectionImpl ultimately owns a RunnerConnection, which in
turn spins up a new thread. If we don't explicitly tear this down then
we leak that thread.

BUG=590472
TBR=ben@chromium.org
==========

[Ken Rockot(use gerrit already), 2016-02-29 21:49:48]

Actually TBRing since it's P0 and the change is obviously safe IMHO

[Ken Rockot(use gerrit already), 2016-02-29 21:49:52]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2016-02-29 21:50:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1748093002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1748093002/1

[Ben Goodger (Google), 2016-02-29 22:10:00]

lgtm

[commit-bot: I haz the power, 2016-02-29 22:33:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-29 22:33:50]

Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Ken Rockot(use gerrit already), 2016-02-29 23:16:12]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-02-29 23:16:12]

The patchset sent to the CQ was uploaded after l-g-t-m from ben@chromium.org
Link to the patchset: https://codereview.chromium.org/1748093002/#ps20001
(title: "fix mojo ChildProcessHost for external process management")

[commit-bot: I haz the power, 2016-02-29 23:16:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1748093002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1748093002/20001

[commit-bot: I haz the power, 2016-03-01 02:50:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-01 02:50:58]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ken Rockot(use gerrit already), 2016-03-01 03:05:56]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2016-03-01 03:06:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1748093002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1748093002/20001

[Ken Rockot(use gerrit already), 2016-03-01 04:17:39]

Alright, linux_android_rel_ng is incredibly flaky right now and I'm fairly
confident it has nothing to do with this CL. Going to manually land this so it
gets in the next canary.

[commit-bot: I haz the power, 2016-03-01 04:20:37]

Description was changed from

==========
Clean up MojoShellConnection in render processes

MojoShellConnectionImpl ultimately owns a RunnerConnection, which in
turn spins up a new thread. If we don't explicitly tear this down then
we leak that thread.

BUG=590472
TBR=ben@chromium.org
==========

to

==========
Clean up MojoShellConnection in render processes

MojoShellConnectionImpl ultimately owns a RunnerConnection, which in
turn spins up a new thread. If we don't explicitly tear this down then
we leak that thread.

BUG=590472
R=ben@chromium.org
TBR=ben@chromium.org

Committed: https://crrev.com/6cb09bb59dd7ed4dcd37e14c32586ea25490f896
Cr-Commit-Position: refs/heads/master@{#378394}
==========

[commit-bot: I haz the power, 2016-03-01 04:20:37]

Patchset 2 (id:??) landed as
https://crrev.com/6cb09bb59dd7ed4dcd37e14c32586ea25490f896
Cr-Commit-Position: refs/heads/master@{#378394}

[Ken Rockot(use gerrit already), 2016-03-01 04:21:19]

Description was changed from

==========
Clean up MojoShellConnection in render processes

MojoShellConnectionImpl ultimately owns a RunnerConnection, which in
turn spins up a new thread. If we don't explicitly tear this down then
we leak that thread.

BUG=590472
R=ben@chromium.org
TBR=ben@chromium.org

Committed: https://crrev.com/6cb09bb59dd7ed4dcd37e14c32586ea25490f896
Cr-Commit-Position: refs/heads/master@{#378394}
==========

to

==========
Clean up MojoShellConnection in render processes

MojoShellConnectionImpl ultimately owns a RunnerConnection, which in
turn spins up a new thread. If we don't explicitly tear this down then
we leak that thread.

BUG=590472
R=ben@chromium.org
TBR=ben@chromium.org

Committed:
https://chromium.googlesource.com/chromium/src/+/6cb09bb59dd7ed4dcd37e14c3258...
==========

[Ken Rockot(use gerrit already), 2016-03-01 04:21:20]

Committed patchset #2 (id:20001) manually as
6cb09bb59dd7ed4dcd37e14c32586ea25490f896 (presubmit successful).

[Will Harris, 2016-03-01 04:39:50]

thanks for manually landing this.

[boliu, 2016-03-01 23:02:47]

Yes, linux_android_rel_ng is flaky, but there really was a test broken by this.
See crbug.com/591190