Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1746153002:
Add swizzle for rgb8888. (Closed)
DescriptionAdd swizzle for rgb8888.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1746153002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Committed: https://skia.googlesource.com/skia/+/fd5a26080d4647cc913f5f2b2dc72cb35abac3ab
Patch Set 1 #Patch Set 2 : Add needed neon operators. #Patch Set 3 : What was I thinking? #
Total comments: 8
Patch Set 4 : address comments #
Total comments: 6
Patch Set 5 : change to clearer enum. #
Total comments: 2
Patch Set 6 : clean up constructor tree. #Patch Set 7 : Make constructors clean and disconnect from sample spans cl. #
Messages
Total messages: 39 (15 generated)
Description was changed from ========== Add swizzle for rgb8888. BUG=skia: ========== to ========== Add swizzle for rgb8888. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot ==========
Description was changed from ========== Add swizzle for rgb8888. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot ========== to ========== Add swizzle for rgb8888. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot ==========
herb@google.com changed reviewers: + mtklein@google.com, reed@google.com
The CQ bit was checked by herb@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1746153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1746153002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
Add needed neon operators.
The CQ bit was checked by herb@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1746153002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1746153002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
What was I thinking?
The CQ bit was checked by herb@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1746153002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1746153002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
mtklein@chromium.org changed reviewers: + mtklein@chromium.org
https://codereview.chromium.org/1746153002/diff/40001/src/core/SkLinearBitmap... File src/core/SkLinearBitmapPipeline.cpp (right): https://codereview.chromium.org/1746153002/diff/40001/src/core/SkLinearBitmap... src/core/SkLinearBitmapPipeline.cpp:718: kSwizzle = true, Let's call this kSwapRB or kSwap02? It'd be nice to make explicit what swizzle we're up to. https://codereview.chromium.org/1746153002/diff/40001/src/core/SkLinearBitmap... src/core/SkLinearBitmapPipeline.cpp:762: bytePixel = SkNx_shuffle<2, 1, 0, 3>(bytePixel); Is there some reason we need to swap the bytes before converting to float? It's probably simpler to swap the floats, and faster on more machines. https://codereview.chromium.org/1746153002/diff/40001/src/core/SkLinearBitmap... src/core/SkLinearBitmapPipeline.cpp:766: if (kSRGB_SkColorProfileType == colorProfile) { This seems fine if you like this style, but I think we've got plenty enough warnings to catch a typo here that it doesn't matter. https://codereview.chromium.org/1746153002/diff/40001/src/core/SkLinearBitmap... src/core/SkLinearBitmapPipeline.cpp:940: if (kN32_SkColorType == imageInfo.colorType()) { remove
https://codereview.chromium.org/1746153002/diff/40001/src/core/SkLinearBitmap... File src/core/SkLinearBitmapPipeline.cpp (right): https://codereview.chromium.org/1746153002/diff/40001/src/core/SkLinearBitmap... src/core/SkLinearBitmapPipeline.cpp:718: kSwizzle = true, On 2016/02/29 20:15:54, mtklein_C wrote: > Let's call this kSwapRB or kSwap02? It'd be nice to make explicit what swizzle > we're up to. Done. https://codereview.chromium.org/1746153002/diff/40001/src/core/SkLinearBitmap... src/core/SkLinearBitmapPipeline.cpp:762: bytePixel = SkNx_shuffle<2, 1, 0, 3>(bytePixel); On 2016/02/29 20:15:54, mtklein_C wrote: > Is there some reason we need to swap the bytes before converting to float? > It's probably simpler to swap the floats, and faster on more machines. Done. https://codereview.chromium.org/1746153002/diff/40001/src/core/SkLinearBitmap... src/core/SkLinearBitmapPipeline.cpp:766: if (kSRGB_SkColorProfileType == colorProfile) { On 2016/02/29 20:15:54, mtklein_C wrote: > This seems fine if you like this style, but I think we've got plenty enough > warnings to catch a typo here that it doesn't matter. Great. I do not like yoda ==. https://codereview.chromium.org/1746153002/diff/40001/src/core/SkLinearBitmap... src/core/SkLinearBitmapPipeline.cpp:940: if (kN32_SkColorType == imageInfo.colorType()) { On 2016/02/29 20:15:54, mtklein_C wrote: > remove Done.
address comments
https://codereview.chromium.org/1746153002/diff/60001/src/core/SkLinearBitmap... File src/core/SkLinearBitmapPipeline.cpp (right): https://codereview.chromium.org/1746153002/diff/60001/src/core/SkLinearBitmap... src/core/SkLinearBitmapPipeline.cpp:716: enum ShouldSizzle { spelling.... let's either make this an enum class or give the values _ShouldSizzle suffixes like we normally do for enums. I'd prefer enum class. https://codereview.chromium.org/1746153002/diff/60001/src/core/SkLinearBitmap... src/core/SkLinearBitmapPipeline.cpp:718: k8888RBSwap = true, I don't understand why 8888 is important here? https://codereview.chromium.org/1746153002/diff/60001/src/core/SkLinearBitmap... src/core/SkLinearBitmapPipeline.cpp:720: template <SkColorProfileType colorProfile, ShouldSizzle swizzle = k8888Passthrough> I think this might read more clearly without a default. This is an important parameter, not an option.
change to clearer enum.
https://codereview.chromium.org/1746153002/diff/60001/src/core/SkLinearBitmap... File src/core/SkLinearBitmapPipeline.cpp (right): https://codereview.chromium.org/1746153002/diff/60001/src/core/SkLinearBitmap... src/core/SkLinearBitmapPipeline.cpp:716: enum ShouldSizzle { On 2016/02/29 21:34:07, mtklein wrote: > spelling.... > > let's either make this an enum class or give the values _ShouldSizzle suffixes > like we normally do for enums. I'd prefer enum class. Done. https://codereview.chromium.org/1746153002/diff/60001/src/core/SkLinearBitmap... src/core/SkLinearBitmapPipeline.cpp:718: k8888RBSwap = true, On 2016/02/29 21:34:07, mtklein wrote: > I don't understand why 8888 is important here? Acknowledged. https://codereview.chromium.org/1746153002/diff/60001/src/core/SkLinearBitmap... src/core/SkLinearBitmapPipeline.cpp:720: template <SkColorProfileType colorProfile, ShouldSizzle swizzle = k8888Passthrough> On 2016/02/29 21:34:07, mtklein wrote: > I think this might read more clearly without a default. This is an important > parameter, not an option. Done.
lgtm https://codereview.chromium.org/1746153002/diff/80001/src/core/SkLinearBitmap... File src/core/SkLinearBitmapPipeline.cpp (right): https://codereview.chromium.org/1746153002/diff/80001/src/core/SkLinearBitmap... src/core/SkLinearBitmapPipeline.cpp:924: sampleStage->Initialize<Sampler<Pixel8888<kSRGB_SkColorProfileType, these calls to Initialize() are not very pretty.
clean up constructor tree.
Make constructors clean and disconnect from sample spans cl.
The CQ bit was checked by herb@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1746153002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1746153002/120001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by herb@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com Link to the patchset: https://codereview.chromium.org/1746153002/#ps120001 (title: "Make constructors clean and disconnect from sample spans cl.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1746153002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1746153002/120001
Message was sent while issue was closed.
Description was changed from ========== Add swizzle for rgb8888. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot ========== to ========== Add swizzle for rgb8888. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Committed: https://skia.googlesource.com/skia/+/fd5a26080d4647cc913f5f2b2dc72cb35abac3ab ==========
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as https://skia.googlesource.com/skia/+/fd5a26080d4647cc913f5f2b2dc72cb35abac3ab
Message was sent while issue was closed.
https://codereview.chromium.org/1746153002/diff/80001/src/core/SkLinearBitmap... File src/core/SkLinearBitmapPipeline.cpp (right): https://codereview.chromium.org/1746153002/diff/80001/src/core/SkLinearBitmap... src/core/SkLinearBitmapPipeline.cpp:924: sampleStage->Initialize<Sampler<Pixel8888<kSRGB_SkColorProfileType, On 2016/02/29 22:04:26, mtklein wrote: > these calls to Initialize() are not very pretty. Very pretty now! |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
