Add swizzle for rgb8888.

src/core/SkLinearBitmapPipeline.cpp

 /*
  * Copyright 2016 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkLinearBitmapPipeline.h"
 #include "SkPM4f.h"
 
@@ skipping 695 matching lines @@
 }
 
 class sRGBFast {
 public:
     static Sk4s VECTORCALL sRGBToLinear(Sk4s pixel) {
         Sk4s l = pixel * pixel;
         return Sk4s{l[0], l[1], l[2], pixel[3]};
     }
 };
 
-template <SkColorProfileType colorProfile>
-class RGBA8888 {
+enum ShouldSizzle {

[mtklein, 2016/02/29 21:34:07]

spelling....

let's either make this an enum class or give the values _ShouldSizzle suffixes
like we normally do for enums.  I'd prefer enum class.

[herb_g, 2016/02/29 21:54:56]

Done.

+    k8888Passthrough = false,
+    k8888RBSwap = true,

[mtklein, 2016/02/29 21:34:07]

I don't understand why 8888 is important here?

[herb_g, 2016/02/29 21:54:56]

Acknowledged.

+};
+template <SkColorProfileType colorProfile, ShouldSizzle swizzle = k8888Passthrough>

[mtklein, 2016/02/29 21:34:07]

I think this might read more clearly without a default.  This is an important
parameter, not an option.

[herb_g, 2016/02/29 21:54:56]

Done.

+class Pixel8888 {
 public:
-    RGBA8888(int width, const uint32_t* src)
+    Pixel8888(int width, const uint32_t* src)
         : fSrc{src}, fWidth{width}{ }
 
     void VECTORCALL getFewPixels(int n, Sk4s xs, Sk4s ys, Sk4f* px0, Sk4f* px1, Sk4f* px2) {
         Sk4i XIs = SkNx_cast<int, SkScalar>(xs);
         Sk4i YIs = SkNx_cast<int, SkScalar>(ys);
         Sk4i bufferLoc = YIs * fWidth + XIs;
         switch (n) {
             case 3:
                 *px2 = this->getPixel(fSrc, bufferLoc[2]);
             case 2:
@@ skipping 18 matching lines @@
     void get4Pixels(const uint32_t* src, int index, Sk4f* px0, Sk4f* px1, Sk4f* px2, Sk4f* px3) {
         *px0 = this->getPixel(src, index + 0);
         *px1 = this->getPixel(src, index + 1);
         *px2 = this->getPixel(src, index + 2);
         *px3 = this->getPixel(src, index + 3);
     }
 
     Sk4f getPixel(const uint32_t* src, int index) {
         Sk4b bytePixel = Sk4b::Load((uint8_t *)(&src[index]));
         Sk4f pixel = SkNx_cast<float, uint8_t>(bytePixel);
+        if (swizzle == k8888RBSwap) {
+            pixel = SkNx_shuffle<2, 1, 0, 3>(pixel);
+        }
         pixel = pixel * Sk4f{1.0f/255.0f};
         if (colorProfile == kSRGB_SkColorProfileType) {
             pixel = sRGBFast::sRGBToLinear(pixel);
         }
         return pixel;
     }
 
     const uint32_t* row(int y) { return fSrc + y * fWidth[0]; }
 
 private:
@@ skipping 144 matching lines @@
     SourceStrategy fStrategy;
 };
 
 static SkLinearBitmapPipeline::BilerpProcessorInterface* choose_pixel_sampler(
     SkLinearBitmapPipeline::PixelPlacerInterface* next,
     const SkPixmap& srcPixmap,
     SkLinearBitmapPipeline::SampleStage* sampleStage) {
     const SkImageInfo& imageInfo = srcPixmap.info();
     switch (imageInfo.colorType()) {
         case kRGBA_8888_SkColorType:
+            if (imageInfo.profileType() == kSRGB_SkColorProfileType) {
+                sampleStage->Initialize<Sampler<Pixel8888<kSRGB_SkColorProfileType>>>(
+                    next, static_cast<int>(srcPixmap.rowBytes() / 4),
+                    srcPixmap.addr32());
+            } else {
+                sampleStage->Initialize<Sampler<Pixel8888<kLinear_SkColorProfileType>>>(
+                    next, static_cast<int>(srcPixmap.rowBytes() / 4),
+                    srcPixmap.addr32());
+            }
+            break;
         case kBGRA_8888_SkColorType:
-            if (kN32_SkColorType == imageInfo.colorType()) {
-                if (imageInfo.profileType() == kSRGB_SkColorProfileType) {
-                    sampleStage->Initialize<Sampler<RGBA8888<kSRGB_SkColorProfileType>>>(
-                        next, static_cast<int>(srcPixmap.rowBytes() / 4),
-                        srcPixmap.addr32());
-                } else {
-                    sampleStage->Initialize<Sampler<RGBA8888<kLinear_SkColorProfileType>>>(
-                        next, static_cast<int>(srcPixmap.rowBytes() / 4),
-                        srcPixmap.addr32());
-                }
+            if (imageInfo.profileType() == kSRGB_SkColorProfileType) {
+                sampleStage->Initialize<Sampler<Pixel8888<kSRGB_SkColorProfileType, k8888RBSwap>>>(
+                    next, static_cast<int>(srcPixmap.rowBytes() / 4),
+                    srcPixmap.addr32());
             } else {
-                SkFAIL("Not implemented. No 8888 Swizzle");
+                sampleStage->Initialize<Sampler<Pixel8888<kLinear_SkColorProfileType, k8888RBSwap>>>(
+                    next, static_cast<int>(srcPixmap.rowBytes() / 4),
+                    srcPixmap.addr32());
             }
             break;
         default:
             SkFAIL("Not implemented. Unsupported src");
             break;
     }
     return sampleStage->get();
 }
 
 template <SkAlphaType alphaType>
@@ skipping 68 matching lines @@
 
 void SkLinearBitmapPipeline::shadeSpan4f(int x, int y, SkPM4f* dst, int count) {
     SkASSERT(count > 0);
     fPixelStage->setDestination(dst);
     // The count and length arguments start out in a precise relation in order to keep the
     // math correct through the different stages. Count is the number of pixel to produce.
     // Since the code samples at pixel centers, length is the distance from the center of the
     // first pixel to the center of the last pixel. This implies that length is count-1.
     fFirstStage->pointSpan(Span{SkPoint{x + 0.5f, y + 0.5f}, count - 1.0f, count});
 }