Issue 1745783002: Revert "Force __pnacl_pso_root to be an external declaration."

Issue 1745783002: Revert "Force __pnacl_pso_root to be an external declaration." (Closed)

Created:
4 years, 9 months ago by Jim Stichnoth

Modified:
4 years, 9 months ago

Reviewers:
Mark Seaborn, Sean Klein, Karl, John

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Force __pnacl_pso_root to be an external declaration." This reverts commit 352db9354e9c30f99c6f87674f70a6f23a9ef7eb from https://codereview.chromium.org/1740033002/ . That commit broke "make -f Makefile.standalone check-lit check-xtest". BUG= none R=smklein@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=7de95ea1cd542a6e622a7f007d9400bb8693ab5e

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -26 lines)			Patch
	M	src/IceGlobalInits.h	View		5 chunks	+5 lines, -20 lines	0 comments	Download
	M	src/PNaClTranslator.cpp	View		1 chunk	+0 lines, -6 lines	0 comments	Download

Total messages: 6 (3 generated)

Jim Stichnoth

One needs to run "make -f Makefile.standalone presubmit" before landing.

4 years, 9 months ago (2016-02-27 17:27:28 UTC) #3

Jim Stichnoth

4 years, 9 months ago (2016-02-29 17:14:15 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7de95ea1cd542a6e622a7f007d9400bb8693ab5e (presubmit successful).