Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: src/PNaClTranslator.cpp

Issue 1745783002: Revert "Force __pnacl_pso_root to be an external declaration." (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceGlobalInits.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/PNaClTranslator.cpp
diff --git a/src/PNaClTranslator.cpp b/src/PNaClTranslator.cpp
index edee9e5241c54975623de047a83335a47746d06d..1fb84c16b76e32f44592ed8670210b7e12031439 100644
--- a/src/PNaClTranslator.cpp
+++ b/src/PNaClTranslator.cpp
@@ -476,12 +476,6 @@ private:
const char *DeclType,
NaClBcIndexSize_t &NameIndex) {
if (Decl->hasName()) {
- if (Decl->isPNaClABIExternalName()) {
- // Force linkage to be external for the PNaCl ABI. PNaCl bitcode has a
- // linkage field for Functions, but not for GlobalVariables (because the
- // latter is not needed for pexes, so it has been removed).
- Decl->setLinkage(llvm::GlobalValue::ExternalLinkage);
- }
Translator.checkIfUnnamedNameSafe(Decl->getName(), DeclType, Prefix);
} else {
Decl->setName(Translator.createUnnamedName(Prefix, NameIndex));
« no previous file with comments | « src/IceGlobalInits.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698