Fix ChromeOS-only static initializers from the last 5 months.

Fix ChromeOS-only static initializers from the last 5 months.

BUG=537099
Committed: https://crrev.com/3315cc8506cfffc3cad3c62d18eff4d4fd89293c
Cr-Commit-Position: refs/heads/master@{#386513}

[Lei Zhang, 2016-02-27 02:15:44]

thestig@chromium.org changed reviewers:
+ asvitkine@chromium.org, dhsharp@chromium.org, sky@chromium.org,
yawano@chromium.org

[Lei Zhang, 2016-02-27 02:15:45]

Since there's no bot to watch for this, I periodically remember to fix these.
See bug for details.

sky: ash/ https://codereview.chromium.org/1676713002
yawano: drive/ https://codereview.chromium.org/1414753005
dhsharp or asvitkine: metrics/ https://codereview.chromium.org/1399703002

[dhsharp, 2016-02-27 03:05:24]

For metrics, I don't see that there's anything to fix. I was very careful to
make CollectionParams a POD type so that kDefaultParameters could be initialized
by the compiler, and not by static initialization. How did you determine that
this needs fixing?

https://codereview.chromium.org/1745723002/diff/1/chrome/browser/metrics/perf...
File chrome/browser/metrics/perf/perf_provider_chromeos.cc (right):

https://codereview.chromium.org/1745723002/diff/1/chrome/browser/metrics/perf...
chrome/browser/metrics/perf/perf_provider_chromeos.cc:194: :
CollectionParams(base::TimeDelta::FromSeconds(2),
Please at least restore the comments for what these values are.

[sky, 2016-02-29 16:41:29]

LGTM

[Alexei Svitkine (slow), 2016-02-29 17:54:48]

I suspect it's the calls to base::TimeDelta::From*() that require a static
initializer - since code needs to be run to compute those. The compiler isn't
smart enough to do the calculation during compile time and avoid the static
init.

[yawano, 2016-03-01 01:41:27]

c/b/c/drive: lgtm

[Lei Zhang, 2016-03-29 18:58:04]

On 2016/02/27 03:05:24, dhsharp wrote:
> For metrics, I don't see that there's anything to fix. I was very careful to
> make CollectionParams a POD type so that kDefaultParameters could be
initialized
> by the compiler, and not by static initialization. How did you determine that
> this needs fixing?

If you do a component=static_library chromeos=1 Release build, you can run
tools/linux/dump-static-initializers.py and see the list. I posted the list for
this CL in https://bugs.chromium.org/p/chromium/issues/detail?id=537099#c9 .

CollectionParams is all POD types, but |kDefaultParameters| uses
base::TimeDelta, which is not.

[Lei Zhang, 2016-03-29 19:03:45]

https://codereview.chromium.org/1745723002/diff/1/chrome/browser/metrics/perf...
File chrome/browser/metrics/perf/perf_provider_chromeos.cc (right):

https://codereview.chromium.org/1745723002/diff/1/chrome/browser/metrics/perf...
chrome/browser/metrics/perf/perf_provider_chromeos.cc:194: :
CollectionParams(base::TimeDelta::FromSeconds(2),
On 2016/02/27 03:05:24, dhsharp wrote:
> Please at least restore the comments for what these values are.

Done.

[Lei Zhang, 2016-04-05 00:30:55]

dhsharp: Please take a look at the metrics changes when you have a chance.

[Lei Zhang, 2016-04-11 19:29:52]

On 2016/04/05 00:30:55, Lei Zhang wrote:
> dhsharp: Please take a look at the metrics changes when you have a chance.

ping

[dhsharp, 2016-04-11 19:44:15]

LGTM

Disappointed my original approach didn't work, but okay.

[Alexei Svitkine (slow), 2016-04-11 20:31:02]

lgtm

[Lei Zhang, 2016-04-11 21:30:47]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2016-04-11 21:30:47]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org,
yawano@chromium.org
Link to the patchset: https://codereview.chromium.org/1745723002/#ps20001
(title: "rebase, address dhsharp comment")

[commit-bot: I haz the power, 2016-04-11 21:32:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1745723002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1745723002/20001

[commit-bot: I haz the power, 2016-04-11 23:23:08]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-11 23:25:22]

Description was changed from

==========
Fix ChromeOS-only static initializers from the last 5 months.

BUG=537099
==========

to

==========
Fix ChromeOS-only static initializers from the last 5 months.

BUG=537099

Committed: https://crrev.com/3315cc8506cfffc3cad3c62d18eff4d4fd89293c
Cr-Commit-Position: refs/heads/master@{#386513}
==========

[commit-bot: I haz the power, 2016-04-11 23:25:23]

Patchset 2 (id:??) landed as
https://crrev.com/3315cc8506cfffc3cad3c62d18eff4d4fd89293c
Cr-Commit-Position: refs/heads/master@{#386513}