ash/mash: Add a mus-client that sets up ash to provide the system ui for mash.

ash/mash: Add a mus-client that sets up ash to provide the system ui for mash.

We only want a small number of the components of ash (e.g. shelf, wallpaper,
system-tray, app-list) etc. for mash, but for now, the mus-client loads all of
ash. The bare minimum set of delegates have stub implementations. These will
grow as we hook them up with other mojo/mus services.

BUG=585141
Landed in crrev.com/374470, reverted in crrev.com/374483 because broke cros.

Committed: https://crrev.com/ffeadfa8cecbb85276bf7bf25d428107c6230437
Cr-Commit-Position: refs/heads/master@{#374558}

[sadrul, 2016-02-05 23:24:20]

sadrul@chromium.org changed reviewers:
+ sky@chromium.org

[sadrul, 2016-02-05 23:24:20]

This is now ready for a formal review.

[sadrul, 2016-02-08 17:32:19]

Description was changed from

==========
ash/mash: Add a mus-client that sets up ash to provide the system ui for mash.

All of ash is currently loaded in the mus-client, but

We only want a small number of the components of ash (e.g. shelf, wallpaper,
system-tray, app-list) etc. for mash, but for now, the mus-client loads all of
ash. The bare minimum set of delegates have stub implementations. These will
grow as we hook them up with other mojo/mus services.

BUG=none
==========

to

==========
ash/mash: Add a mus-client that sets up ash to provide the system ui for mash.

We only want a small number of the components of ash (e.g. shelf, wallpaper,
system-tray, app-list) etc. for mash, but for now, the mus-client loads all of
ash. The bare minimum set of delegates have stub implementations. These will
grow as we hook them up with other mojo/mus services.

BUG=none
==========

[sadrul, 2016-02-08 17:33:56]

Description was changed from

==========
ash/mash: Add a mus-client that sets up ash to provide the system ui for mash.

We only want a small number of the components of ash (e.g. shelf, wallpaper,
system-tray, app-list) etc. for mash, but for now, the mus-client loads all of
ash. The bare minimum set of delegates have stub implementations. These will
grow as we hook them up with other mojo/mus services.

BUG=none
==========

to

==========
ash/mash: Add a mus-client that sets up ash to provide the system ui for mash.

We only want a small number of the components of ash (e.g. shelf, wallpaper,
system-tray, app-list) etc. for mash, but for now, the mus-client loads all of
ash. The bare minimum set of delegates have stub implementations. These will
grow as we hook them up with other mojo/mus services.

BUG=585141
==========

[sky, 2016-02-08 17:42:15]

https://codereview.chromium.org/1676713002/diff/1/ash/mus/sysui/shell_delegat...
File ash/mus/sysui/shell_delegate_mus.cc (right):

https://codereview.chromium.org/1676713002/diff/1/ash/mus/sysui/shell_delegat...
ash/mus/sysui/shell_delegate_mus.cc:80: return false;
Is it worth NOTIMPLEMENTEDs for all of these?

https://codereview.chromium.org/1676713002/diff/1/ash/mus/sysui/sysui_applica...
File ash/mus/sysui/sysui_application.cc (right):

https://codereview.chromium.org/1676713002/diff/1/ash/mus/sysui/sysui_applica...
ash/mus/sysui/sysui_application.cc:34: class AshWindowTreeHostMus : public
AshWindowTreeHostPlatform {
Document this creates a stub window, it doesn't display anything.

https://codereview.chromium.org/1676713002/diff/1/ui/base/user_activity/user_...
File ui/base/user_activity/user_activity_detector.cc (right):

https://codereview.chromium.org/1676713002/diff/1/ui/base/user_activity/user_...
ui/base/user_activity/user_activity_detector.cc:56: // XXX(sad): Need a PES for
mus.
XXX->TODO

https://codereview.chromium.org/1676713002/diff/1/ui/views/mus/native_widget_...
File ui/views/mus/native_widget_mus.cc (right):

https://codereview.chromium.org/1676713002/diff/1/ui/views/mus/native_widget_...
ui/views/mus/native_widget_mus.cc:193: // WindowTreeHost creates the compositor
using the ContextFactory from
Seems better to do initialization in InitNativeWidget. I say this as I suspect
InitNativeWidget is going to get more complicated. How come creating the
WindowTreeHost needed to be here?

[sadrul, 2016-02-08 18:33:24]

https://codereview.chromium.org/1676713002/diff/1/ash/mus/sysui/shell_delegat...
File ash/mus/sysui/shell_delegate_mus.cc (right):

https://codereview.chromium.org/1676713002/diff/1/ash/mus/sysui/shell_delegat...
ash/mus/sysui/shell_delegate_mus.cc:80: return false;
On 2016/02/08 17:42:15, sky wrote:
> Is it worth NOTIMPLEMENTEDs for all of these?

Done.

https://codereview.chromium.org/1676713002/diff/1/ash/mus/sysui/sysui_applica...
File ash/mus/sysui/sysui_application.cc (right):

https://codereview.chromium.org/1676713002/diff/1/ash/mus/sysui/sysui_applica...
ash/mus/sysui/sysui_application.cc:34: class AshWindowTreeHostMus : public
AshWindowTreeHostPlatform {
On 2016/02/08 17:42:15, sky wrote:
> Document this creates a stub window, it doesn't display anything.

Done.

https://codereview.chromium.org/1676713002/diff/1/ui/base/user_activity/user_...
File ui/base/user_activity/user_activity_detector.cc (right):

https://codereview.chromium.org/1676713002/diff/1/ui/base/user_activity/user_...
ui/base/user_activity/user_activity_detector.cc:56: // XXX(sad): Need a PES for
mus.
On 2016/02/08 17:42:15, sky wrote:
> XXX->TODO

Done.

https://codereview.chromium.org/1676713002/diff/1/ui/views/mus/native_widget_...
File ui/views/mus/native_widget_mus.cc (right):

https://codereview.chromium.org/1676713002/diff/1/ui/views/mus/native_widget_...
ui/views/mus/native_widget_mus.cc:193: // WindowTreeHost creates the compositor
using the ContextFactory from
On 2016/02/08 17:42:15, sky wrote:
> Seems better to do initialization in InitNativeWidget. I say this as I suspect
> InitNativeWidget is going to get more complicated. How come creating the
> WindowTreeHost needed to be here?

We need to install the RootWindowSettings for the WTH's root-window between the
creation of the WTHMus, and the call to InitHost(). (because the call to
InitHost() goes back to the associated gfx::Display (to learn about the
device-scale-factor)).

That is why this CL splits the creation of the WTHMus and the call to
WTH::InitHost(). The injected NativeWidgetFactory can then set-up the
RootWindowSettings object at the right time so that subsequent initialization
can completely correctly.

An alternate approach is to keep this code in
NativeWidgetMus::InitNativeWidget(), but introduce a virtual method which gets
called between the WTH creation and the call to InitHost(), so that (1)
NativeWidgetFactory can create a AshNativeWidgetMus, instead of a
NativeWidgetMus from the WMC, and (2) AshNativeWidgetMus overrides the
introduced virtual method to inject the RWH on the root-window. That feels just
as clunky to me, but happy to do that if you think that's cleaner.

[sky, 2016-02-08 20:26:03]

Ok, go with this for now. If we need to change the ordering later on we can.
LGTM

[sadrul, 2016-02-08 23:29:57]

The CQ bit was checked by sadrul@chromium.org

[commit-bot: I haz the power, 2016-02-08 23:34:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1676713002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1676713002/40001

[commit-bot: I haz the power, 2016-02-08 23:53:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-08 23:53:43]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sadrul, 2016-02-08 23:59:47]

sadrul@chromium.org changed reviewers:
+ vmpstr@chromium.org

[sadrul, 2016-02-08 23:59:48]

+vmpstr@ for cc owner (//ash/mus/sysui/DEPS includes cc to be able to impement
StubContextFactory (stub_context_factory.cc))

[sky, 2016-02-09 18:24:44]

Thanks for shuffling directories around, SLGTM

[vmpstr, 2016-02-09 19:20:25]

lgtm, but maybe we should also move single thread task graph runner stuff
somewhere more generic (I think that's the dependency right?)

[sadrul, 2016-02-09 19:27:35]

On 2016/02/09 19:20:25, vmpstr wrote:
> lgtm, but maybe we should also move single thread task graph runner stuff
> somewhere more generic (I think that's the dependency right?)

Thanks!

The dependency does include SingleThreadTaskGraphRunner, but it also includes
SurfaceIdAllocator(), since the ui::Compositor expects a non-null instance, and
ContextProvider (since the ui::ContextFactory API uses a
scoped_refptr<cc::ContextProvider>, and it needs to know that it can be
ref-counted.

[vmpstr, 2016-02-09 19:28:48]

On 2016/02/09 19:27:35, sadrul wrote:
> On 2016/02/09 19:20:25, vmpstr wrote:
> > lgtm, but maybe we should also move single thread task graph runner stuff
> > somewhere more generic (I think that's the dependency right?)
> 
> Thanks!
> 
> The dependency does include SingleThreadTaskGraphRunner, but it also includes
> SurfaceIdAllocator(), since the ui::Compositor expects a non-null instance,
and
> ContextProvider (since the ui::ContextFactory API uses a
> scoped_refptr<cc::ContextProvider>, and it needs to know that it can be
> ref-counted.

Ah cool, thanks for the explanation.

[sadrul, 2016-02-09 20:20:52]

The CQ bit was checked by sadrul@chromium.org

[sadrul, 2016-02-09 20:20:52]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1676713002/#ps80001
(title: "tot-merge")

[commit-bot: I haz the power, 2016-02-09 20:22:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1676713002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1676713002/80001

[commit-bot: I haz the power, 2016-02-09 21:18:31]

Description was changed from

==========
ash/mash: Add a mus-client that sets up ash to provide the system ui for mash.

We only want a small number of the components of ash (e.g. shelf, wallpaper,
system-tray, app-list) etc. for mash, but for now, the mus-client loads all of
ash. The bare minimum set of delegates have stub implementations. These will
grow as we hook them up with other mojo/mus services.

BUG=585141
==========

to

==========
ash/mash: Add a mus-client that sets up ash to provide the system ui for mash.

We only want a small number of the components of ash (e.g. shelf, wallpaper,
system-tray, app-list) etc. for mash, but for now, the mus-client loads all of
ash. The bare minimum set of delegates have stub implementations. These will
grow as we hook them up with other mojo/mus services.

BUG=585141
==========

[commit-bot: I haz the power, 2016-02-09 21:18:32]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-02-09 21:20:37]

Description was changed from

==========
ash/mash: Add a mus-client that sets up ash to provide the system ui for mash.

We only want a small number of the components of ash (e.g. shelf, wallpaper,
system-tray, app-list) etc. for mash, but for now, the mus-client loads all of
ash. The bare minimum set of delegates have stub implementations. These will
grow as we hook them up with other mojo/mus services.

BUG=585141
==========

to

==========
ash/mash: Add a mus-client that sets up ash to provide the system ui for mash.

We only want a small number of the components of ash (e.g. shelf, wallpaper,
system-tray, app-list) etc. for mash, but for now, the mus-client loads all of
ash. The bare minimum set of delegates have stub implementations. These will
grow as we hook them up with other mojo/mus services.

BUG=585141

Committed: https://crrev.com/dfd7833ae942a8339853ed02907bb31e0806badc
Cr-Commit-Position: refs/heads/master@{#374470}
==========

[commit-bot: I haz the power, 2016-02-09 21:20:39]

Patchset 5 (id:??) landed as
https://crrev.com/dfd7833ae942a8339853ed02907bb31e0806badc
Cr-Commit-Position: refs/heads/master@{#374470}

[iclelland, 2016-02-09 21:45:21]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1683853003/ by iclelland@chromium.org.

The reason for reverting is: This CL is breaking the build. See
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...

The linker error is
[1834/2095] SOLINK ./libash_sysui_library.so
FAILED: python
"/b/build/slave/Linux_ChromiumOS_GN__dbg_/build/src/build/toolchain/gcc_solink_wrapper.py"
--readelf="readelf" --nm="nm"  --sofile="./libash_sysui_library.so"
--tocfile="./libash_sysui_library.so.TOC" --output="./libash_sysui_library.so"
-- ../../third_party/llvm-build/Release+Asserts/bin/clang++ -shared
-Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro
-Wl,-z,defs -B../../third_party/binutils/Linux_x64/Release/bin -fuse-ld=gold
-Wl,--icf=all -pthread -m64 -Wl,--export-dynamic -o "./libash_sysui_library.so"
-Wl,-soname="libash_sysui_library.so" @"./libash_sysui_library.so.rsp"
../../ash/mus/shell_delegate_mus.cc:23: error: undefined reference to
'user_manager::UserInfoImpl::UserInfoImpl()'
../../ash/mus/sysui_application.cc:126: error: undefined reference to
'message_center::MessageCenter::Initialize()'
clang: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.
.

[waffles, 2016-02-09 21:45:41]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1684803002/ by waffles@chromium.org.

The reason for reverting is: Causes Linux chromiumos GN compilation failures:

../../ash/mus/shell_delegate_mus.cc:23: error: undefined reference to
'user_manager::UserInfoImpl::UserInfoImpl()'
../../ash/mus/sysui_application.cc:126: error: undefined reference to
'message_center::MessageCenter::Initialize()'.

[sadrul, 2016-02-09 21:59:30]

Description was changed from

==========
ash/mash: Add a mus-client that sets up ash to provide the system ui for mash.

We only want a small number of the components of ash (e.g. shelf, wallpaper,
system-tray, app-list) etc. for mash, but for now, the mus-client loads all of
ash. The bare minimum set of delegates have stub implementations. These will
grow as we hook them up with other mojo/mus services.

BUG=585141

Committed: https://crrev.com/dfd7833ae942a8339853ed02907bb31e0806badc
Cr-Commit-Position: refs/heads/master@{#374470}
==========

to

==========
ash/mash: Add a mus-client that sets up ash to provide the system ui for mash.

We only want a small number of the components of ash (e.g. shelf, wallpaper,
system-tray, app-list) etc. for mash, but for now, the mus-client loads all of
ash. The bare minimum set of delegates have stub implementations. These will
grow as we hook them up with other mojo/mus services.

BUG=585141

Committed: https://crrev.com/dfd7833ae942a8339853ed02907bb31e0806badc
Cr-Commit-Position: refs/heads/master@{#374470}
==========

[sadrul, 2016-02-09 22:18:18]

Description was changed from

==========
ash/mash: Add a mus-client that sets up ash to provide the system ui for mash.

We only want a small number of the components of ash (e.g. shelf, wallpaper,
system-tray, app-list) etc. for mash, but for now, the mus-client loads all of
ash. The bare minimum set of delegates have stub implementations. These will
grow as we hook them up with other mojo/mus services.

BUG=585141

Committed: https://crrev.com/dfd7833ae942a8339853ed02907bb31e0806badc
Cr-Commit-Position: refs/heads/master@{#374470}
==========

to

==========
ash/mash: Add a mus-client that sets up ash to provide the system ui for mash.

We only want a small number of the components of ash (e.g. shelf, wallpaper,
system-tray, app-list) etc. for mash, but for now, the mus-client loads all of
ash. The bare minimum set of delegates have stub implementations. These will
grow as we hook them up with other mojo/mus services.

BUG=585141

Landed in crrev.com/374470, reverted in crrev.com/374483 because broke cros.
==========

[sadrul, 2016-02-09 22:29:16]

The CQ bit was checked by sadrul@chromium.org

[sadrul, 2016-02-09 22:29:16]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org,
vmpstr@chromium.org
Link to the patchset: https://codereview.chromium.org/1676713002/#ps100001
(title: "fix-cros-build")

[commit-bot: I haz the power, 2016-02-09 22:34:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1676713002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1676713002/100001

[sadrul, 2016-02-09 22:37:54]

On 2016/02/09 22:34:47, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1676713002/100001
> View timeline at
>  https://chromium-cq-status.appspot.com/patch-timeline/1676713002/100001

The reason for the build-breakage was because of missing dependencies on
//ui/message_center and //components/user_manager. I have added the dependencies
(diff between patchsets 5 and 6 in //ash/mus/BUILD.gn)

[commit-bot: I haz the power, 2016-02-09 23:46:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-09 23:46:10]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sadrul, 2016-02-09 23:50:21]

The CQ bit was checked by sadrul@chromium.org

[commit-bot: I haz the power, 2016-02-09 23:52:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1676713002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1676713002/100001

[commit-bot: I haz the power, 2016-02-10 00:59:09]

Description was changed from

==========
ash/mash: Add a mus-client that sets up ash to provide the system ui for mash.

We only want a small number of the components of ash (e.g. shelf, wallpaper,
system-tray, app-list) etc. for mash, but for now, the mus-client loads all of
ash. The bare minimum set of delegates have stub implementations. These will
grow as we hook them up with other mojo/mus services.

BUG=585141

Landed in crrev.com/374470, reverted in crrev.com/374483 because broke cros.
==========

to

==========
ash/mash: Add a mus-client that sets up ash to provide the system ui for mash.

We only want a small number of the components of ash (e.g. shelf, wallpaper,
system-tray, app-list) etc. for mash, but for now, the mus-client loads all of
ash. The bare minimum set of delegates have stub implementations. These will
grow as we hook them up with other mojo/mus services.

BUG=585141

Landed in crrev.com/374470, reverted in crrev.com/374483 because broke cros.
==========

[commit-bot: I haz the power, 2016-02-10 00:59:09]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-02-10 01:00:44]

Description was changed from

==========
ash/mash: Add a mus-client that sets up ash to provide the system ui for mash.

We only want a small number of the components of ash (e.g. shelf, wallpaper,
system-tray, app-list) etc. for mash, but for now, the mus-client loads all of
ash. The bare minimum set of delegates have stub implementations. These will
grow as we hook them up with other mojo/mus services.

BUG=585141

Landed in crrev.com/374470, reverted in crrev.com/374483 because broke cros.
==========

to

==========
ash/mash: Add a mus-client that sets up ash to provide the system ui for mash.

We only want a small number of the components of ash (e.g. shelf, wallpaper,
system-tray, app-list) etc. for mash, but for now, the mus-client loads all of
ash. The bare minimum set of delegates have stub implementations. These will
grow as we hook them up with other mojo/mus services.

BUG=585141

Landed in crrev.com/374470, reverted in crrev.com/374483 because broke cros.

Committed: https://crrev.com/ffeadfa8cecbb85276bf7bf25d428107c6230437
Cr-Commit-Position: refs/heads/master@{#374558}
==========

[commit-bot: I haz the power, 2016-02-10 01:00:47]

Patchset 6 (id:??) landed as
https://crrev.com/ffeadfa8cecbb85276bf7bf25d428107c6230437
Cr-Commit-Position: refs/heads/master@{#374558}