Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1745663003: Revert of [Android WebView] Implement support for Network Information API and enable it. (Closed)

Created:
4 years, 10 months ago by sgurun-gerrit only
Modified:
4 years, 10 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android WebView] Implement support for Network Information API and enable it. (patchset #6 id:100001 of https://codereview.chromium.org/1659363003/ ) Reason for revert: caused crbug/590383 Original issue's description: > [Android WebView] Implement support for Network Information API and enable it. > > Currently Network Information API and everything related to the > NetworkChangeNotifier is disabled in WebView. This patch implements > the required parts to enable Network Information API in WebView. > > The WebView implementation is based on NetworkChangeNotifier, > similar to chrome for Android. However the registration policy > is different: > 1. whether we listen to network changes depends on the presence > of live WebView instances, > 2. both the band-width and connectivity changes are propagated, > but a reduced network stack is involved as compared to the chrome > for android implementation, > 3. for backward compatibility invoking setNetworkAvailable() on a > webview disables network information api. > > BUG=520088 > > Committed: https://crrev.com/3673455317898f450211636919c2bef7a8e3fe0f > Cr-Commit-Position: refs/heads/master@{#376975} TBR=torne@chromium.org,pauljensen@chromium.org,timvolodine@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=520088 Committed: https://crrev.com/8d212a4cdf1f26a12bb22e9009fcdf3e73325905 Cr-Commit-Position: refs/heads/master@{#378061}

Patch Set 1 #

Messages

Total messages: 11 (5 generated)
sgurun-gerrit only
Created Revert of [Android WebView] Implement support for Network Information API and enable it.
4 years, 10 months ago (2016-02-26 23:50:55 UTC) #1
sgurun-gerrit only
On 2016/02/26 23:50:55, sgurun wrote: > Created Revert of [Android WebView] Implement support for Network ...
4 years, 10 months ago (2016-02-26 23:51:46 UTC) #4
sgurun-gerrit only
On 2016/02/26 23:51:46, sgurun wrote: > On 2016/02/26 23:50:55, sgurun wrote: > > Created Revert ...
4 years, 10 months ago (2016-02-27 00:09:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1745663003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1745663003/1
4 years, 10 months ago (2016-02-27 00:11:50 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-27 01:45:05 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-27 01:46:07 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8d212a4cdf1f26a12bb22e9009fcdf3e73325905
Cr-Commit-Position: refs/heads/master@{#378061}

Powered by Google App Engine
This is Rietveld 408576698