android_webview/java/src/org/chromium/android_webview/AwContents.java - Issue 1745663003: Revert of [Android WebView] Implement support for Network Information API and enable it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContents.java

Issue 1745663003: Revert of [Android WebView] Implement support for Network Information API and enable it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java ('k') | android_webview/java/src/org/chromium/android_webview/AwNetworkChangeNotifierRegistrationPolicy.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/src/org/chromium/android_webview/AwContents.java

diff --git a/android_webview/java/src/org/chromium/android_webview/AwContents.java b/android_webview/java/src/org/chromium/android_webview/AwContents.java

index 7ec965fc3d99361dcb6e23176503ebc399a93f3e..a710d513896e2f65cc45be90c0a0c6231c552b5f 100644

--- a/android_webview/java/src/org/chromium/android_webview/AwContents.java

+++ b/android_webview/java/src/org/chromium/android_webview/AwContents.java

@@ -69,7 +69,6 @@

import org.chromium.content_public.browser.navigation_controller.UserAgentOverrideOption;

import org.chromium.content_public.common.Referrer;

import org.chromium.net.NetError;

-import org.chromium.net.NetworkChangeNotifier;

import org.chromium.ui.base.ActivityWindowAndroid;

import org.chromium.ui.base.PageTransition;

import org.chromium.ui.base.WindowAndroid;

@@ -2537,13 +2536,7 @@

public void setNetworkAvailable(boolean networkUp) {

if (TRACE) Log.d(TAG, "setNetworkAvailable=%s", networkUp);

- if (!isDestroyed(WARN)) {

- // For backward compatibility when an app uses this API disable the

- // Network Information API to prevent inconsistencies,

- // see crbug.com/520088.

- NetworkChangeNotifier.setAutoDetectConnectivityState(false);

- nativeSetJsOnlineProperty(mNativeAwContents, networkUp);

- }

+ if (!isDestroyed(WARN)) nativeSetJsOnlineProperty(mNativeAwContents, networkUp);

}

/**