Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 17455: Autofill popup dismissed when page loses focus (Closed)

Created:
11 years, 11 months ago by jcampan
Modified:
9 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

The popup for autofill is now never activated, even when clicked. This allows us to hide it when the page loses focus. (doing that previously would have caused the popup to be hidden before the click in the popup was sent to the renderer). Most of the file changes are just renaming focus_on_show to activatable. TEST=Open a form and make an autofill popup. Focus another window, the popup should disappear. Ensure the autofill still work properly, and the combo-box as well. BUG=3844, 5830 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7823

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -65 lines) Patch
M chrome/browser/render_view_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/render_view_host.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/render_view_host_delegate.h View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/render_widget_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/render_widget_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/render_widget_host_view_win.h View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/render_widget_host_view_win.cc View 1 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/resource_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resource_message_filter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/web_contents_view.h View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/web_contents_view.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/web_contents_view_win.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_contents_view_win.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/render_messages_internal.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/mock_render_thread.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/mock_render_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/render_view.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/renderer/render_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/render_widget.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/renderer/render_widget.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M webkit/glue/chrome_client_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/chrome_client_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/glue/webview_delegate.h View 1 chunk +1 line, -2 lines 0 comments Download
M webkit/glue/webview_impl.cc View 3 chunks +3 lines, -9 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
jcampan
This fix is only for the autofill popup. Fixing the combo-box popup focus will be ...
11 years, 11 months ago (2009-01-09 19:05:22 UTC) #1
sky
11 years, 11 months ago (2009-01-09 19:16:52 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698