Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 1745433002: Add back Vk files with LF endings (Closed)

Created:
4 years, 9 months ago by jvanverth1
Modified:
4 years, 9 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Re-add to gyp #

Patch Set 3 : Rebase to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1027 lines, -6 lines) Patch
M gyp/gpu.gypi View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
A src/gpu/vk/GrVkProgram.h View 1 2 1 chunk +161 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkProgram.cpp View 1 2 1 chunk +367 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkProgramBuilder.cpp View 1 2 1 chunk +323 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkProgramDataManager.h View 1 2 1 chunk +70 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkSampler.cpp View 1 2 1 chunk +74 lines, -0 lines 0 comments Download
A src/gpu/vk/GrVkVaryingHandler.cpp View 1 2 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
jvanverth1
When I rebase this with ToT this should add them back.
4 years, 9 months ago (2016-02-26 16:38:51 UTC) #3
egdaniel
lgtm, again with possible gyp issue.
4 years, 9 months ago (2016-02-26 16:40:57 UTC) #4
jvanverth1
On 2016/02/26 16:40:57, egdaniel wrote: > lgtm, again with possible gyp issue. Done.
4 years, 9 months ago (2016-02-26 17:08:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1745433002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1745433002/40001
4 years, 9 months ago (2016-02-26 17:08:31 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-02-26 17:21:05 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/992ad363d7ca879cdb86f802b379f06800a44125

Powered by Google App Engine
This is Rietveld 408576698