third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py - Issue 1745423002: DevTools: migrate protocol values from RefPtr to OwnPtr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py

Issue 1745423002: DevTools: migrate protocol values from RefPtr to OwnPtr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.cpp ('k') | third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_cpp.template » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py

diff --git a/third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py b/third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py

index 0d0a87ab7f2265af48f672c64353e35a48df8b56..43c9c56c4dba0de63a5f98ba43e3067d394a850d 100644

--- a/third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py

+++ b/third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py

@@ -115,27 +115,27 @@ def create_user_type_definition(domain_name, type):

def create_object_type_definition():

return {

- "return_type": "PassRefPtr<protocol::DictionaryValue>",

- "pass_type": "PassRefPtr<protocol::DictionaryValue>",

- "to_raw_type": "%s",

+ "return_type": "PassOwnPtr<protocol::DictionaryValue>",

+ "pass_type": "PassOwnPtr<protocol::DictionaryValue>",

+ "to_raw_type": "%s.get()",

"to_pass_type": "%s.release()",

- "type": "RefPtr<protocol::DictionaryValue>",

- "raw_type": "RefPtr<protocol::DictionaryValue>",

- "raw_pass_type": "PassRefPtr<protocol::DictionaryValue>",

- "raw_return_type": "RefPtr<protocol::DictionaryValue>",

+ "type": "OwnPtr<protocol::DictionaryValue>",

+ "raw_type": "protocol::DictionaryValue",

+ "raw_pass_type": "protocol::DictionaryValue*",

+ "raw_return_type": "protocol::DictionaryValue*",

}

def create_any_type_definition():

return {

- "return_type": "PassRefPtr<protocol::Value>",

- "pass_type": "PassRefPtr<protocol::Value>",

+ "return_type": "PassOwnPtr<protocol::Value>",

+ "pass_type": "PassOwnPtr<protocol::Value>",

+ "to_raw_type": "%s.get()",

"to_pass_type": "%s.release()",

- "to_raw_type": "%s",

- "type": "RefPtr<protocol::Value>",

- "raw_type": "RefPtr<protocol::Value>",

- "raw_pass_type": "PassRefPtr<protocol::Value>",

- "raw_return_type": "RefPtr<protocol::Value>",

+ "type": "OwnPtr<protocol::Value>",

+ "raw_type": "protocol::Value",

+ "raw_pass_type": "protocol::Value*",

+ "raw_return_type": "protocol::Value*",

}