fpdfsdk/src/pdfwindow/PWL_ListCtrl.cpp - Issue 1745243002: Pass rect by const reference in SetClip_Rect().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/pdfwindow/PWL_ListCtrl.cpp

Issue 1745243002: Pass rect by const reference in SetClip_Rect(). (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/src/pdfwindow/PWL_ListCtrl.cpp

diff --git a/fpdfsdk/src/pdfwindow/PWL_ListCtrl.cpp b/fpdfsdk/src/pdfwindow/PWL_ListCtrl.cpp

index 1c32ceb251071e02cf496de3ad89d537271fe39b..7c2c1f4d17763b789f39af33262b39ecac8d2a1f 100644

--- a/fpdfsdk/src/pdfwindow/PWL_ListCtrl.cpp

+++ b/fpdfsdk/src/pdfwindow/PWL_ListCtrl.cpp

@@ -141,10 +141,8 @@ void CPWL_ListCtrl::DrawChildAppearance(CFX_RenderDevice* pDevice,

CFX_FloatRect rcClient = GetClientRect();

CFX_FloatRect rcTemp = rcClient;

pUser2Device->TransformRect(rcTemp);

- FX_RECT rcClip((int32_t)rcTemp.left, (int32_t)rcTemp.bottom,

- (int32_t)rcTemp.right, (int32_t)rcTemp.top);

- pDevice->SetClip_Rect(&rcClip);

+ pDevice->SetClip_Rect(FX_RECT((int32_t)rcTemp.left, (int32_t)rcTemp.bottom,

dsinclair 2016/02/29 21:15:26 This is ... upside down?

Tom Sepez 2016/02/29 21:17:45 Has been since day 1 ... 9d8ec5a6 (Nico Weber

+ (int32_t)rcTemp.right, (int32_t)rcTemp.top));

for (int32_t i = 0, sz = m_aChildren.GetSize(); i < sz; i++) {

if (CPWL_Wnd* pChild = m_aChildren.GetAt(i)) {