Renew deprecation messages for Web Audio doppler effects

Renew deprecation messages for Web Audio doppler effects

Intent to Deprecate:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/-1SI1GoHYO8/6XUjRs-fdv4J

BUG=439644
Committed: https://crrev.com/15b8b644ebf25a156b7e1046fabbc54e0e9be64d
Cr-Commit-Position: refs/heads/master@{#378409}

[philipj_slow, 2016-02-29 16:30:22]

The CQ bit was checked by philipj@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-29 16:30:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1745103002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1745103002/1

[philipj_slow, 2016-02-29 16:42:26]

Description was changed from

==========
Renew deprecation messages for Web Audio doppler effects

Intent to Deprecate:
https://mail.google.com/mail/u/0/#drafts?compose=15307fbec6ba331f

BUG=439644
==========

to

==========
Renew deprecation messages for Web Audio doppler effects

Intent to Deprecate:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/-1SI1GoHYO8/6XUjRs-f...

BUG=439644
==========

[philipj_slow, 2016-02-29 17:15:46]

philipj@opera.com changed reviewers:
+ isherman@chromium.org, rtoy@chromium.org

[philipj_slow, 2016-02-29 17:15:47]

PTAL, and see blink-dev thread for context.

[philipj_slow, 2016-02-29 17:22:07]

On 2016/02/29 17:15:47, philipj_UTC7 wrote:
> PTAL, and see blink-dev thread for context.

I have also tweaked the chromestatus.com entry a bit.

[Raymond Toy, 2016-02-29 17:22:27]

lgtm with nits

https://codereview.chromium.org/1745103002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/webaudio/doppler-deprecated.html (right):

https://codereview.chromium.org/1745103002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/doppler-deprecated.html:4: <div
id="console"></div>
I don't think the description and console divs are needed anymore; js-test.js
handles them.

https://codereview.chromium.org/1745103002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/Deprecation.cpp (right):

https://codereview.chromium.org/1745103002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/Deprecation.cpp:53: return
String::format("%s is deprecated and will be removed in %s. It has no effect as
the Web Audio doppler effects have already been removed internally. See
https://www.chromestatus.com/features/%s for more details.", feature,
milestoneString(milestone), details);
A bit verbose, but I really like such informative messages!

[commit-bot: I haz the power, 2016-02-29 19:10:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-29 19:10:06]

Dry run: This issue passed the CQ dry run.

[Ilya Sherman, 2016-02-29 22:09:23]

histograms.xml lgtm

[philipj_slow, 2016-03-01 05:27:05]

https://codereview.chromium.org/1745103002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/webaudio/doppler-deprecated.html (right):

https://codereview.chromium.org/1745103002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/doppler-deprecated.html:4: <div
id="console"></div>
On 2016/02/29 17:22:27, Raymond Toy wrote:
> I don't think the description and console divs are needed anymore; js-test.js
> handles them.

Done.

https://codereview.chromium.org/1745103002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/Deprecation.cpp (right):

https://codereview.chromium.org/1745103002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/Deprecation.cpp:53: return
String::format("%s is deprecated and will be removed in %s. It has no effect as
the Web Audio doppler effects have already been removed internally. See
https://www.chromestatus.com/features/%s for more details.", feature,
milestoneString(milestone), details);
On 2016/02/29 17:22:27, Raymond Toy wrote:
> A bit verbose, but I really like such informative messages!

I went back and forth trying to make it more compact, but I wasn't quite sure
something like "a deprecated no-op" would be immediately understood, so I went
the verbose path. Glad you don't mind :)

[philipj_slow, 2016-03-01 05:27:11]

The CQ bit was checked by philipj@opera.com

[philipj_slow, 2016-03-01 05:27:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org, rtoy@chromium.org
Link to the patchset: https://codereview.chromium.org/1745103002/#ps20001
(title: "remove cruft")

[commit-bot: I haz the power, 2016-03-01 05:27:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1745103002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1745103002/20001

[commit-bot: I haz the power, 2016-03-01 06:54:32]

Description was changed from

==========
Renew deprecation messages for Web Audio doppler effects

Intent to Deprecate:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/-1SI1GoHYO8/6XUjRs-f...

BUG=439644
==========

to

==========
Renew deprecation messages for Web Audio doppler effects

Intent to Deprecate:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/-1SI1GoHYO8/6XUjRs-f...

BUG=439644
==========

[commit-bot: I haz the power, 2016-03-01 06:54:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-01 06:55:39]

Description was changed from

==========
Renew deprecation messages for Web Audio doppler effects

Intent to Deprecate:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/-1SI1GoHYO8/6XUjRs-f...

BUG=439644
==========

to

==========
Renew deprecation messages for Web Audio doppler effects

Intent to Deprecate:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/-1SI1GoHYO8/6XUjRs-f...

BUG=439644

Committed: https://crrev.com/15b8b644ebf25a156b7e1046fabbc54e0e9be64d
Cr-Commit-Position: refs/heads/master@{#378409}
==========

[commit-bot: I haz the power, 2016-03-01 06:55:40]

Patchset 2 (id:??) landed as
https://crrev.com/15b8b644ebf25a156b7e1046fabbc54e0e9be64d
Cr-Commit-Position: refs/heads/master@{#378409}