Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Unified Diff: third_party/WebKit/Source/core/frame/Deprecation.cpp

Issue 1745103002: Renew deprecation messages for Web Audio doppler effects (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove cruft Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/Deprecation.cpp
diff --git a/third_party/WebKit/Source/core/frame/Deprecation.cpp b/third_party/WebKit/Source/core/frame/Deprecation.cpp
index 592d4f615f85f407a71c3fb8b429a8fff00039df..65f6557d7f49423e8b70a9ddeb444881b0fbeb22 100644
--- a/third_party/WebKit/Source/core/frame/Deprecation.cpp
+++ b/third_party/WebKit/Source/core/frame/Deprecation.cpp
@@ -30,6 +30,8 @@ const char* milestoneString(int milestone)
return "M53, around September 2016";
case 54:
return "M54, around October 2016";
+ case 55:
+ return "M55, around November 2016";
}
ASSERT_NOT_REACHED();
@@ -46,6 +48,11 @@ String willBeRemoved(const char* feature, int milestone, const char* details)
return String::format("%s is deprecated and will be removed in %s. See https://www.chromestatus.com/features/%s for more details.", feature, milestoneString(milestone), details);
}
+String dopplerWillBeRemoved(const char* feature, int milestone, const char* details)
+{
+ return String::format("%s is deprecated and will be removed in %s. It has no effect as the Web Audio doppler effects have already been removed internally. See https://www.chromestatus.com/features/%s for more details.", feature, milestoneString(milestone), details);
+}
+
String replacedWillBeRemoved(const char* feature, const char* replacement, int milestone, const char* details)
{
return String::format("%s is deprecated and will be removed in %s. Please use %s instead. See https://www.chromestatus.com/features/%s for more details.", feature, milestoneString(milestone), replacement, details);
@@ -236,13 +243,16 @@ String Deprecation::deprecationMessage(UseCounter::Feature feature)
return replacedBy("'CanvasRenderingContext2D.webkitImageSmoothingEnabled'", "'CanvasRenderingContext2D.imageSmoothingEnabled'");
case UseCounter::AudioListenerDopplerFactor:
- return "dopplerFactor is deprecated and will be removed in M45 when all doppler effects are removed";
+ return dopplerWillBeRemoved("'AudioListener.dopplerFactor'", 55, "5238926818148352");
case UseCounter::AudioListenerSpeedOfSound:
- return "speedOfSound is deprecated and will be removed in M45 when all doppler effects are removed";
+ return dopplerWillBeRemoved("'AudioListener.speedOfSound'", 55, "5238926818148352");
case UseCounter::AudioListenerSetVelocity:
- return "setVelocity() is deprecated and will be removed in M45 when all doppler effects are removed";
+ return dopplerWillBeRemoved("'AudioListener.setVelocity()'", 55, "5238926818148352");
+
+ case UseCounter::PannerNodeSetVelocity:
+ return dopplerWillBeRemoved("'PannerNode.setVelocity()'", 55, "5238926818148352");
case UseCounter::PrefixedWindowURL:
return replacedBy("'webkitURL'", "'URL'");

Powered by Google App Engine
This is Rietveld 408576698