chrome/renderer/resources/extensions/storage_area.js - Issue 17451011: Make the externally connectable browser test clobber all of the builtins,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/storage_area.js

Issue 17451011: Make the externally connectable browser test clobber all of the builtins, (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/resources/extensions/send_request.js ('k') | chrome/renderer/resources/extensions/sync_file_system_custom_bindings.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/storage_area.js

diff --git a/chrome/renderer/resources/extensions/storage_area.js b/chrome/renderer/resources/extensions/storage_area.js

index 07496024e8d6c853ab1fc9bfffb6c4db3f1a475c..66d57d41d5e47eca1b1c2a541839e4cfbcd82d8c 100644

--- a/chrome/renderer/resources/extensions/storage_area.js

+++ b/chrome/renderer/resources/extensions/storage_area.js

@@ -7,7 +7,7 @@ var normalizeArgumentsAndValidate =

var sendRequest = require('sendRequest').sendRequest;

function extendSchema(schema) {

- var extendedSchema = schema.slice();

+ var extendedSchema = $Array.slice(schema);

extendedSchema.unshift({'type': 'string'});

return extendedSchema;

}

@@ -24,11 +24,11 @@ function StorageArea(namespace, schema) {

function bindApiFunction(functionName) {

self[functionName] = function() {

var funSchema = this.functionSchemas[functionName];

- var args = Array.prototype.slice.call(arguments);

+ var args = $Array.slice(arguments);

args = normalizeArgumentsAndValidate(args, funSchema);

return sendRequest(

'storage.' + functionName,

- [namespace].concat(args),

+ $Array.concat([namespace], args),

extendSchema(funSchema.definition.parameters),

{preserveNullInObjects: true});

};