Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3946)

Unified Diff: chrome/renderer/resources/extensions/send_request.js

Issue 17451011: Make the externally connectable browser test clobber all of the builtins, (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/send_request.js
diff --git a/chrome/renderer/resources/extensions/send_request.js b/chrome/renderer/resources/extensions/send_request.js
index 1e203ca354457d4a758d441c935cada82c11c5a9..28798baafcbfd9fd65eab2569346043e383a5d80 100644
--- a/chrome/renderer/resources/extensions/send_request.js
+++ b/chrome/renderer/resources/extensions/send_request.js
@@ -18,7 +18,7 @@ var calledSendRequest = false;
// Runs a user-supplied callback safely.
function safeCallbackApply(name, request, callback, args) {
try {
- callback.apply(request, args);
+ $Function.apply(callback, request, args);
} catch (e) {
var errorMessage = "Error in response to " + name + ": " + e;
if (request.stack && request.stack != '')
@@ -44,7 +44,7 @@ function handleResponse(requestId, name, success, responseList, error) {
if (request.callback) {
var chromeForCallback = natives.GetGlobal(request.callback).chrome;
if (chromeForCallback != chrome)
- chromesForLastError.push(chromeForCallback);
+ $Array.push(chromesForLastError, chromeForCallback);
}
$Array.forEach(chromesForLastError, function(c) {lastError.clear(c)});
@@ -60,7 +60,7 @@ function handleResponse(requestId, name, success, responseList, error) {
safeCallbackApply(name,
request,
request.customCallback,
- [name, request].concat(responseList));
+ $Array.concat([name, request], responseList));
}
if (request.callback) {
@@ -82,7 +82,7 @@ function handleResponse(requestId, name, success, responseList, error) {
};
function getExtensionStackTrace(call_name) {
- var stack = new Error().stack.split('\n');
+ var stack = $String.split(new Error().stack, '\n');
// Remove stack frames before and after that weren't associated with the
// extension.
« no previous file with comments | « chrome/renderer/resources/extensions/searchbox_api.js ('k') | chrome/renderer/resources/extensions/storage_area.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698