Implementation of CSS3 nav-up/down/left/right properties from CSS3 UI.

Source/core/css/CSSParser.cpp

Index: Source/core/css/CSSParser.cpp
diff --git a/Source/core/css/CSSParser.cpp b/Source/core/css/CSSParser.cpp
index ba53d7ddbc0bcf820799b47580a800348905e856..595b7ba688abb2ec6b9b2ec5d48991e6baea0021 100644
--- a/Source/core/css/CSSParser.cpp
+++ b/Source/core/css/CSSParser.cpp
@@ -7,6 +7,7 @@
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved.
  * Copyright (C) 2012 Intel Corporation. All rights reserved.
+ * Copyright (C) 2013 Opera Software ASA. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ -2287,6 +2288,25 @@ bool CSSParser::parseValue(CSSPropertyID propId, bool important)
 
         validPrimitive = true;
         break;
+    case CSSPropertyNavDown: // auto | <id> targetframe | inherit
+    case CSSPropertyNavLeft:
+    case CSSPropertyNavRight:
+    case CSSPropertyNavUp:
+        if (id == CSSValueAuto
+            || (num == 1 && (value->unit == CSSPrimitiveValue::CSS_STRING || value->unit == CSSPrimitiveValue::CSS_PARSER_HEXCOLOR))) {
+            value->unit = CSSPrimitiveValue::CSS_STRING;
+            validPrimitive = true;
+        } else if (num == 2) {
+            RefPtr<CSSValueList> list = CSSValueList::createSpaceSeparated();
+            while (value) {
+                list->append(cssValuePool().createValue(value->string, CSSPrimitiveValue::CSS_STRING));
+                value = m_valueList->next();
+            }
+            parsedValue = list.release();
+        } else {
+            return false;

[esprehn, 2013/06/20 19:45:10]

It'd be nicer if you split out these cases more, It's code to have a little code
duplication (ex. for the Auto case and the num == 1 case in separate parts of
the if() else if () so you have three cases.

Also I think you're missing a return true?

[Krzysztof Olczyk, 2013/07/22 14:14:16]

Done
 
No, we need additional common handling at the end of this function.

+        }
+        break;
     case CSSPropertyWebkitFlex: {
         ShorthandScope scope(this, propId);
         if (id == CSSValueNone) {