Implementation of CSS3 nav-up/down/left/right properties from CSS3 UI.

Source/core/css/CSSParser.cpp

 /*
  * Copyright (C) 2003 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com>
  * Copyright (C) 2008 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved.
  * Copyright (C) 2012 Intel Corporation. All rights reserved.
+ * Copyright (C) 2013 Opera Software ASA. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Library General Public License for more details.
@@ skipping 2260 matching lines @@
             }
             return false;
         }
         break;
     case CSSPropertyMixBlendMode:
         if (!RuntimeEnabledFeatures::cssCompositingEnabled())
             return false;
 
         validPrimitive = true;
         break;
+    case CSSPropertyNavDown: // auto | <id> targetframe | inherit
+    case CSSPropertyNavLeft:
+    case CSSPropertyNavRight:
+    case CSSPropertyNavUp:
+        if (id == CSSValueAuto
+            || (num == 1 && (value->unit == CSSPrimitiveValue::CSS_STRING || value->unit == CSSPrimitiveValue::CSS_PARSER_HEXCOLOR))) {
+            value->unit = CSSPrimitiveValue::CSS_STRING;
+            validPrimitive = true;
+        } else if (num == 2) {
+            RefPtr<CSSValueList> list = CSSValueList::createSpaceSeparated();
+            while (value) {
+                list->append(cssValuePool().createValue(value->string, CSSPrimitiveValue::CSS_STRING));
+                value = m_valueList->next();
+            }
+            parsedValue = list.release();
+        } else {
+            return false;

[esprehn, 2013/06/20 19:45:10]

It'd be nicer if you split out these cases more, It's code to have a little code
duplication (ex. for the Auto case and the num == 1 case in separate parts of
the if() else if () so you have three cases.

Also I think you're missing a return true?

[Krzysztof Olczyk, 2013/07/22 14:14:16]

Done
 
No, we need additional common handling at the end of this function.

+        }
+        break;
     case CSSPropertyWebkitFlex: {
         ShorthandScope scope(this, propId);
         if (id == CSSValueNone) {
             addProperty(CSSPropertyWebkitFlexGrow, cssValuePool().createValue(0, CSSPrimitiveValue::CSS_NUMBER), important);
             addProperty(CSSPropertyWebkitFlexShrink, cssValuePool().createValue(0, CSSPrimitiveValue::CSS_NUMBER), important);
             addProperty(CSSPropertyWebkitFlexBasis, cssValuePool().createIdentifierValue(CSSValueAuto), important);
             return true;
         }
         return parseFlex(m_valueList.get(), important);
     }
@@ skipping 9503 matching lines @@
 {
     // The tokenizer checks for the construct of an+b.
     // However, since the {ident} rule precedes the {nth} rule, some of those
     // tokens are identified as string literal. Furthermore we need to accept
     // "odd" and "even" which does not match to an+b.
     return equalIgnoringCase(token, "odd") || equalIgnoringCase(token, "even")
         || equalIgnoringCase(token, "n") || equalIgnoringCase(token, "-n");
 }
 
 }