Implementation of CSS3 nav-up/down/left/right properties from CSS3 UI.

Source/core/css/parser/CSSPropertyParser.cpp

Index: Source/core/css/parser/CSSPropertyParser.cpp
diff --git a/Source/core/css/parser/CSSPropertyParser.cpp b/Source/core/css/parser/CSSPropertyParser.cpp
index e89861130584f9fd6fe30e0908a7b17ff465b241..34bce7e12158c15b5cefd7c5c960e45cd7972217 100644
--- a/Source/core/css/parser/CSSPropertyParser.cpp
+++ b/Source/core/css/parser/CSSPropertyParser.cpp
@@ -1066,6 +1066,28 @@ bool CSSPropertyParser::parseValue(CSSPropertyID propId, bool important)
             return false;
         }
         break;
+    case CSSPropertyNavDown: // auto | <id> targetframe | inherit

[fs, 2014/04/17 15:33:48]

"auto | <id> [ current | root | <target-name> ]? | inherit"

is what the current ED says.

[Krzysztof Olczyk, 2014/09/30 15:41:46]

Done.

+    case CSSPropertyNavLeft:
+    case CSSPropertyNavRight:
+    case CSSPropertyNavUp:
+        if (id == CSSValueAuto) {
+            validPrimitive = true;
+        } else if (value) {
+            RefPtrWillBeRawPtr<CSSValueList> list = CSSValueList::createSpaceSeparated();
+            if (value->unit != CSSPrimitiveValue::CSS_PARSER_IDSEL && value->unit != CSSPrimitiveValue::CSS_PARSER_HEXCOLOR)
+                return false;
+
+            value->unit = CSSPrimitiveValue::CSS_STRING;

[fs, 2014/04/17 15:33:48]

Now I just think that this is unnecessary - what actually needs this mutation?

[Krzysztof Olczyk, 2014/09/30 15:41:46]

Because:
1) CSS_PARSER_HEXCOLOR won't be a nice type of nav-up property :)
2) As far as I understand the CSS code in Blink, all CSS_PARSER_ types should
not trespass this point,
   as those are only the auxiliary types for this kind of disambiguation. 

+            list->append(cssValuePool().createValue(value->string, CSSPrimitiveValue::CSS_STRING));
+            value = m_valueList->next();
+            if (value && value->unit == CSSPrimitiveValue::CSS_STRING) {

[fs, 2014/04/17 15:33:48]

How about the current and root keywords? (Also consider how "current" (the
string) differs from current (the identifier/keyword.))

[Krzysztof Olczyk, 2014/09/30 15:41:47]

Right. Done.

+                if (value->string.startsWithIgnoringCase("_"))

[fs, 2014/04/17 15:33:48]

What's the other case version of _? =P

[Krzysztof Olczyk, 2014/09/30 15:41:47]

:)

I just can't see other non-case-ignoring version of that function in
CSSParserString class,
and as it makes no difference for _, I can't see a sense of converting it to
WTF::String.

+                    return false;
+                list->append(cssValuePool().createValue(value->string, CSSPrimitiveValue::CSS_STRING));
+            }
+            parsedValue = list.release();
+        }
+        break;
     case CSSPropertyFlex: {
         ShorthandScope scope(this, propId);
         if (id == CSSValueNone) {