Implementation of CSS3 nav-up/down/left/right properties from CSS3 UI.

Source/core/css/parser/CSSPropertyParser.cpp

 /*
  * Copyright (C) 2003 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com>
  * Copyright (C) 2008 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved.
  * Copyright (C) 2012 Intel Corporation. All rights reserved.
  *
@@ skipping 1048 matching lines @@
             validPrimitive = true;
         else {
             RefPtrWillBeRawPtr<CSSValue> val = parseFilter();
             if (val) {
                 addProperty(propId, val, important);
                 return true;
             }
             return false;
         }
         break;
+    case CSSPropertyNavDown: // auto | <id> targetframe | inherit

[fs, 2014/04/17 15:33:48]

"auto | <id> [ current | root | <target-name> ]? | inherit"

is what the current ED says.

[Krzysztof Olczyk, 2014/09/30 15:41:46]

Done.

+    case CSSPropertyNavLeft:
+    case CSSPropertyNavRight:
+    case CSSPropertyNavUp:
+        if (id == CSSValueAuto) {
+            validPrimitive = true;
+        } else if (value) {
+            RefPtrWillBeRawPtr<CSSValueList> list = CSSValueList::createSpaceSeparated();
+            if (value->unit != CSSPrimitiveValue::CSS_PARSER_IDSEL && value->unit != CSSPrimitiveValue::CSS_PARSER_HEXCOLOR)
+                return false;
+
+            value->unit = CSSPrimitiveValue::CSS_STRING;

[fs, 2014/04/17 15:33:48]

Now I just think that this is unnecessary - what actually needs this mutation?

[Krzysztof Olczyk, 2014/09/30 15:41:46]

Because:
1) CSS_PARSER_HEXCOLOR won't be a nice type of nav-up property :)
2) As far as I understand the CSS code in Blink, all CSS_PARSER_ types should
not trespass this point,
   as those are only the auxiliary types for this kind of disambiguation. 

+            list->append(cssValuePool().createValue(value->string, CSSPrimitiveValue::CSS_STRING));
+            value = m_valueList->next();
+            if (value && value->unit == CSSPrimitiveValue::CSS_STRING) {

[fs, 2014/04/17 15:33:48]

How about the current and root keywords? (Also consider how "current" (the
string) differs from current (the identifier/keyword.))

[Krzysztof Olczyk, 2014/09/30 15:41:47]

Right. Done.

+                if (value->string.startsWithIgnoringCase("_"))

[fs, 2014/04/17 15:33:48]

What's the other case version of _? =P

[Krzysztof Olczyk, 2014/09/30 15:41:47]

:)

I just can't see other non-case-ignoring version of that function in
CSSParserString class,
and as it makes no difference for _, I can't see a sense of converting it to
WTF::String.

+                    return false;
+                list->append(cssValuePool().createValue(value->string, CSSPrimitiveValue::CSS_STRING));
+            }
+            parsedValue = list.release();
+        }
+        break;
     case CSSPropertyFlex: {
         ShorthandScope scope(this, propId);
         if (id == CSSValueNone) {
             addProperty(CSSPropertyFlexGrow, cssValuePool().createValue(0, CSSPrimitiveValue::CSS_NUMBER), important);
             addProperty(CSSPropertyFlexShrink, cssValuePool().createValue(0, CSSPrimitiveValue::CSS_NUMBER), important);
             addProperty(CSSPropertyFlexBasis, cssValuePool().createIdentifierValue(CSSValueAuto), important);
             return true;
         }
         return parseFlex(m_valueList.get(), important);
     }
@@ skipping 7433 matching lines @@
         parsedValues->append(CSSPrimitiveValue::createIdentifier(CSSValueFill));
     if (!seenStroke)
         parsedValues->append(CSSPrimitiveValue::createIdentifier(CSSValueStroke));
     if (!seenMarkers)
         parsedValues->append(CSSPrimitiveValue::createIdentifier(CSSValueMarkers));
 
     return parsedValues.release();
 }
 
 } // namespace WebCore