Source/core/css/CSSParserValues.cpp - Issue 17450016: Implementation of CSS3 nav-up/down/left/right properties from CSS3 UI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSParserValues.cpp

Issue 17450016: Implementation of CSS3 nav-up/down/left/right properties from CSS3 UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Applied code review suggestions. Also rebased. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/CSSParserValues.cpp

diff --git a/Source/core/css/CSSParserValues.cpp b/Source/core/css/CSSParserValues.cpp

index 4ccb95613b326054b8e72084b27ab19da91548b2..3eb75d096f8be6611c4cb4fa552b7ae64f4e032e 100644

--- a/Source/core/css/CSSParserValues.cpp

+++ b/Source/core/css/CSSParserValues.cpp

@@ -107,6 +107,7 @@ PassRefPtrWillBeRawPtr<CSSValue> CSSParserValue::createCSSValue()

case CSSPrimitiveValue::CSS_STRING:

case CSSPrimitiveValue::CSS_URI:

case CSSPrimitiveValue::CSS_PARSER_HEXCOLOR:

+ case CSSPrimitiveValue::CSS_PARSER_IDSEL:

return CSSPrimitiveValue::create(string, primitiveUnit);

case CSSPrimitiveValue::CSS_PERCENTAGE:

case CSSPrimitiveValue::CSS_EMS:

« Source/core/css/CSSGrammar.y ('K') | « Source/core/css/CSSGrammar.y ('k') | Source/core/css/CSSPrimitiveValue.h » ('j') | Source/core/css/parser/CSSPropertyParser.cpp » ('J')