Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 1744963002: Revert of Implement support for using GL ES 3.0 with command buffer (Closed)

Created:
4 years, 9 months ago by Kimmo Kinnunen
Modified:
4 years, 9 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@no-texture-rectangle-gles
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Implement support for using GL ES 3.0 with command buffer (patchset #6 id:100001 of https://codereview.chromium.org/1684413003/ ) Reason for revert: The dependency, ES3 implementation in command_buffer_gles2, got reverted. Original issue's description: > Implement support for using GL ES 3.0 with command buffer > > Adds a new 'api': --config gpu(api=commandbuffer3) for dm/nanobench. > > BUG=skia:4943 > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1684413003 > > Committed: https://skia.googlesource.com/skia/+/45c2c8166bbd84a87e29fdd344b39e36e8a28a3f TBR=bsalomon@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=skia:4943 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1744963002 Committed: https://skia.googlesource.com/skia/+/f655e9330e3e3cc3d56f19017c89d8309f2ddc36

Patch Set 1 #

Patch Set 2 : rebaes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -139 lines) Patch
M dm/DM.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M dm/DMGpuSupport.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M include/gpu/gl/command_buffer/SkCommandBufferGLContext.h View 1 2 chunks +5 lines, -17 lines 0 comments Download
M include/views/SkOSWindow_Mac.h View 1 1 chunk +1 line, -1 line 0 comments Download
M include/views/SkOSWindow_SDL.h View 1 1 chunk +1 line, -1 line 0 comments Download
M include/views/SkOSWindow_Unix.h View 1 1 chunk +1 line, -1 line 0 comments Download
M include/views/SkOSWindow_Win.h View 1 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleApp.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M samplecode/SampleApp.cpp View 1 4 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/GrContextFactory.h View 1 2 chunks +2 lines, -6 lines 0 comments Download
M src/gpu/GrContextFactory.cpp View 1 1 chunk +2 lines, -5 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 2 chunks +4 lines, -14 lines 0 comments Download
M src/gpu/gl/GrGLInterface.cpp View 1 5 chunks +16 lines, -33 lines 0 comments Download
M src/gpu/gl/command_buffer/SkCommandBufferGLContext.cpp View 1 9 chunks +25 lines, -39 lines 0 comments Download
M src/views/win/SkOSWindow_win.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M tests/TestConfigParsing.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/flags/SkCommonFlagsConfig.cpp View 1 2 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 23 (11 generated)
Kimmo Kinnunen
Created Revert of Implement support for using GL ES 3.0 with command buffer
4 years, 9 months ago (2016-02-29 06:51:29 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1744963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1744963002/1
4 years, 9 months ago (2016-02-29 06:51:52 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 9 months ago (2016-02-29 06:51:53 UTC) #4
Kimmo Kinnunen
To get the implementation back, further work would be needed. I'm not sure I can ...
4 years, 9 months ago (2016-02-29 08:39:55 UTC) #6
commit-bot: I haz the power
Dry run: No LGTM from a valid reviewer yet. Please ask for an LGTM from ...
4 years, 9 months ago (2016-02-29 12:51:07 UTC) #8
bsalomon
sorry, overlooked this. lgtm
4 years, 9 months ago (2016-03-03 00:06:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1744963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1744963002/1
4 years, 9 months ago (2016-03-03 06:45:45 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/6723) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, ...
4 years, 9 months ago (2016-03-03 06:47:43 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1744963002/280001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1744963002/280001
4 years, 9 months ago (2016-03-03 14:01:59 UTC) #16
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-03 14:41:39 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1744963002/280001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1744963002/280001
4 years, 9 months ago (2016-03-03 15:38:34 UTC) #21
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 15:39:52 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:280001) as
https://skia.googlesource.com/skia/+/f655e9330e3e3cc3d56f19017c89d8309f2ddc36

Powered by Google App Engine
This is Rietveld 408576698