Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1744733002: [Tracing] Remove deprecated AddTraceEvent (Closed)

Created:
4 years, 9 months ago by fmeawad
Modified:
4 years, 9 months ago
CC:
Paweł Hajdan Jr., v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Tracing] Remove deprecated AddTraceEvent This should land after the chromium CL that starts using the new AddTraceEvent lands (https://codereview.chromium.org/1742603004/) BUG=4565 LOG=N Committed: https://crrev.com/f3fcdcfa1a68ff2c0a81b729ef38827581f869d8 Cr-Commit-Position: refs/heads/master@{#34412}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -57 lines) Patch
M include/v8-platform.h View 1 chunk +0 lines, -15 lines 0 comments Download
M src/d8.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/libplatform/default-platform.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/libplatform/default-platform.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M test/cctest/heap/test-incremental-marking.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M test/cctest/test-trace-event.cc View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 22 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1744733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1744733002/1
4 years, 9 months ago (2016-02-26 23:45:51 UTC) #2
fmeawad
PTAL.
4 years, 9 months ago (2016-02-26 23:45:56 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/11597)
4 years, 9 months ago (2016-02-26 23:49:27 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1744733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1744733002/1
4 years, 9 months ago (2016-02-26 23:51:01 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_chromium_gn_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/builds/14213)
4 years, 9 months ago (2016-02-27 00:02:26 UTC) #11
jochen (gone - plz use gerrit)
lgtm
4 years, 9 months ago (2016-03-01 14:24:20 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1744733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1744733002/1
4 years, 9 months ago (2016-03-01 18:33:02 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_chromium_gn_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/builds/14355)
4 years, 9 months ago (2016-03-01 18:45:06 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1744733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1744733002/1
4 years, 9 months ago (2016-03-01 21:18:41 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-01 21:20:44 UTC) #20
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 21:20:52 UTC) #22
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f3fcdcfa1a68ff2c0a81b729ef38827581f869d8
Cr-Commit-Position: refs/heads/master@{#34412}

Powered by Google App Engine
This is Rietveld 408576698