Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(999)

Unified Diff: test/cctest/heap/test-incremental-marking.cc

Issue 1744733002: [Tracing] Remove deprecated AddTraceEvent (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/libplatform/default-platform.cc ('k') | test/cctest/test-trace-event.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/heap/test-incremental-marking.cc
diff --git a/test/cctest/heap/test-incremental-marking.cc b/test/cctest/heap/test-incremental-marking.cc
index 54a7fbec0f563c95605bc4da9f85e1ec218e7cb7..74cbf2cb34ed56bec1a91460a6510abc53c4a8a2 100644
--- a/test/cctest/heap/test-incremental-marking.cc
+++ b/test/cctest/heap/test-incremental-marking.cc
@@ -93,15 +93,6 @@ class MockPlatform : public v8::Platform {
return 0;
}
- // TODO(fmeawad): Remove once all embedders implement the scope version.
- uint64_t AddTraceEvent(char phase, const uint8_t* categoryEnabledFlag,
- const char* name, uint64_t id, uint64_t bind_id,
- int numArgs, const char** argNames,
- const uint8_t* argTypes, const uint64_t* argValues,
- unsigned int flags) override {
- return 0;
- }
-
void UpdateTraceEventDuration(const uint8_t* categoryEnabledFlag,
const char* name, uint64_t handle) override {}
« no previous file with comments | « src/libplatform/default-platform.cc ('k') | test/cctest/test-trace-event.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698