[Password Manager] Remove the "manager-for-sync-signin" flags.

[Password Manager] Remove the "manager-for-sync-signin" flags.

The 'disable-manager-for-sync-signin' and 'enable-manager-for-sync-signin' flags
are not effective, Chrome will never fill in GAIA credentials in the Chrome
sign-in page, because of origin mismatch. This patch is a to address this
cleanup.

BUG=586107
Committed: https://crrev.com/4e1217c4841d3e1aecde889e53c36e5e78924966
Cr-Commit-Position: refs/heads/master@{#377889}

[Pritam Nikam, 2016-02-26 13:15:08]

pritam.nikam@samsung.com changed reviewers:
+ vabr@chromium.org, vivekg@chromium.org

[Pritam Nikam, 2016-02-26 13:15:08]

Hi Vaclav, PTAL at this cleanup!
Thanks!

[vabr (Chromium), 2016-02-26 13:32:13]

LGTM, thanks!

[Pritam Nikam, 2016-02-26 14:01:08]

The CQ bit was checked by pritam.nikam@samsung.com

[commit-bot: I haz the power, 2016-02-26 14:02:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1744513002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1744513002/20001

[commit-bot: I haz the power, 2016-02-26 15:06:12]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-26 15:07:44]

Description was changed from

==========
[Password Manager] Remove the "manager-for-sync-signin" flags.

The 'disable-manager-for-sync-signin' and 'enable-manager-for-sync-signin' flags
are not effective, Chrome will never fill in GAIA credentials in the Chrome
sign-in page, because of origin mismatch. This patch is a to address this
cleanup.

BUG=586107
==========

to

==========
[Password Manager] Remove the "manager-for-sync-signin" flags.

The 'disable-manager-for-sync-signin' and 'enable-manager-for-sync-signin' flags
are not effective, Chrome will never fill in GAIA credentials in the Chrome
sign-in page, because of origin mismatch. This patch is a to address this
cleanup.

BUG=586107

Committed: https://crrev.com/4e1217c4841d3e1aecde889e53c36e5e78924966
Cr-Commit-Position: refs/heads/master@{#377889}
==========

[commit-bot: I haz the power, 2016-02-26 15:07:45]

Patchset 2 (id:??) landed as
https://crrev.com/4e1217c4841d3e1aecde889e53c36e5e78924966
Cr-Commit-Position: refs/heads/master@{#377889}

[copasn_student.wayne.k12.in.us, 2016-08-29 10:54:31]

On Friday, February 26, 2016 at 8:15:10 AM UTC-5, pritam...@samsung.com 
wrote:
>
> Reviewers: vabr (away until 7 March), vivekg_
> CL: https://codereview.chromium.org/1744513002/
>
> Message:
>
 

> Hi Vaclav, PTAL at this cleanup!
>
 Hi I would like for you to give it to me so a 13 yearold can under stand

> Thanks!
>

 

>
> Description:
> [Password Manager] Remove the "manager-for-sync-signin" flags.
>
> The 'disable-manager-for-sync-signin' and 'enable-manager-for-sync-signin' 
> flags
> are not effective, Chrome will never fill in GAIA credentials in the Chrome
> sign-in page, because of origin mismatch. This patch is a to address this
> cleanup.
>
> BUG=586107
>
> Base URL: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+0, -34 lines):
> M chrome/browser/password_manager/chrome_password_manager_client.h
> M chrome/browser/password_manager/chrome_password_manager_client.cc
> M components/password_manager/core/common/password_manager_switches.h
> M components/password_manager/core/common/password_manager_switches.cc
>
>
> Index: chrome/browser/password_manager/chrome_password_manager_client.cc
> diff --git 
> a/chrome/browser/password_manager/chrome_password_manager_client.cc 
> b/chrome/browser/password_manager/chrome_password_manager_client.cc
> index 
>
3aa46f59cf73d72232666391514f81825f31b086..a471a95db99cc7fff7e855fafd8a0c61812259ec

> 100644
> --- a/chrome/browser/password_manager/chrome_password_manager_client.cc
> +++ b/chrome/browser/password_manager/chrome_password_manager_client.cc
> @@ -181,8 +181,6 @@ bool 
> ChromePasswordManagerClient::IsPasswordManagementEnabledForCurrentPage()
> if (!entry) {
> // TODO(gcasto): Determine if fix for crbug.com/388246 is relevant here.
> is_enabled = true;
> - } else if (EnabledForSyncSignin()) {
> - is_enabled = true;
> } else {
> // Do not fill nor save password when a user is signing in for sync. This
> // is because users need to remember their password if they are syncing as
> @@ -599,26 +597,6 @@ bool 
> ChromePasswordManagerClient::IsUpdatePasswordUIEnabled() const {
> #endif
> }
>
> -bool ChromePasswordManagerClient::EnabledForSyncSignin() {
> - base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
> - if (command_line->HasSwitch(
> - password_manager::switches::kDisableManagerForSyncSignin))
> - return false;
> -
> - if (command_line->HasSwitch(
> - password_manager::switches::kEnableManagerForSyncSignin))
> - return true;
> -
> - // Default is enabled.
> - std::string group_name =
> - base::FieldTrialList::FindFullName("PasswordManagerStateForSyncSignin");
> - return group_name != "Disabled";
> -}
> -
> -const GURL& ChromePasswordManagerClient::GetMainFrameURL() const {
> - return web_contents()->GetVisibleURL();
> -}
> -
> const GURL& ChromePasswordManagerClient::GetLastCommittedEntryURL() const {
> DCHECK(web_contents());
> content::NavigationEntry* entry =
> Index: chrome/browser/password_manager/chrome_password_manager_client.h
> diff --git 
> a/chrome/browser/password_manager/chrome_password_manager_client.h 
> b/chrome/browser/password_manager/chrome_password_manager_client.h
> index 
>
97b2d4050161ca4c1f4b53da8222a603448e54f7..087e276b7f8d7cac3bfd14f110235778fed68595

> 100644
> --- a/chrome/browser/password_manager/chrome_password_manager_client.h
> +++ b/chrome/browser/password_manager/chrome_password_manager_client.h
> @@ -99,9 +99,6 @@ class ChromePasswordManagerClient
> // the sad old Infobar UI.
> static bool IsTheHotNewBubbleUIEnabled();
>
> - // Returns true if the password manager should be enabled during sync 
> signin.
> - static bool EnabledForSyncSignin();
> -
> protected:
> // Callable for tests.
> ChromePasswordManagerClient(content::WebContents* web_contents,
> Index: components/password_manager/core/common/password_manager_switches.cc
> diff --git 
> a/components/password_manager/core/common/password_manager_switches.cc 
> b/components/password_manager/core/common/password_manager_switches.cc
> index 
>
7dd66b25ef8fea5c0160f644731d7d77395b61ed..abae7eb85f809a4aa773d3d9f8a20eb7eb292a07

> 100644
> --- a/components/password_manager/core/common/password_manager_switches.cc
> +++ b/components/password_manager/core/common/password_manager_switches.cc
> @@ -20,9 +20,6 @@ const char kDisableAffiliationBasedMatching[] =
> // Disable dropping the credential used to sync passwords.
> const char kDisableDropSyncCredential[] = "disable-drop-sync-credential";
>
> -// Disable both saving and filling for the sync signin form.
> -const char kDisableManagerForSyncSignin[] = 
> "disable-manager-for-sync-signin";
> -
> // Disallow autofilling of the sync credential.
> const char kDisallowAutofillSyncCredential[] =
> "disallow-autofill-sync-credential";
> @@ -41,10 +38,6 @@ const char kEnableAffiliationBasedMatching[] =
> // Enable dropping the credential used to sync passwords.
> const char kEnableDropSyncCredential[] = "enable-drop-sync-credential";
>
> -// Enable saving and filling for the sync signin form. Currently the 
> default
> -// behavior.
> -const char kEnableManagerForSyncSignin[] = 
> "enable-manager-for-sync-signin";
> -
> } // namespace switches
>
> } // namespace password_manager
> Index: components/password_manager/core/common/password_manager_switches.h
> diff --git 
> a/components/password_manager/core/common/password_manager_switches.h 
> b/components/password_manager/core/common/password_manager_switches.h
> index 
>
26db746088aef3252d17e632f0d8887dd3b86b56..67e0843118ee35c7c06cf9cf5e4e41fb7b9d0ab2

> 100644
> --- a/components/password_manager/core/common/password_manager_switches.h
> +++ b/components/password_manager/core/common/password_manager_switches.h
> @@ -15,12 +15,10 @@ namespace switches {
> extern const char kAllowAutofillSyncCredential[];
> extern const char kDisableAffiliationBasedMatching[];
> extern const char kDisableDropSyncCredential[];
> -extern const char kDisableManagerForSyncSignin[];
> extern const char kDisallowAutofillSyncCredential[];
> extern const char kDisallowAutofillSyncCredentialForReauth[];
> extern const char kEnableAffiliationBasedMatching[];
> extern const char kEnableDropSyncCredential[];
> -extern const char kEnableManagerForSyncSignin[];
>
> } // namespace switches
>
>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.