Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: src/ast.h

Issue 17444011: Fix to_boolean type feedback for unary and binary ops (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/arm/lithium-codegen-arm.cc ('k') | src/ast.cc » ('j') | src/ast.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ast.h
diff --git a/src/ast.h b/src/ast.h
index 249f7c0149be72cbfc7eb34da83e0b05c5511fb7..239d51083ff035bba5c1cea6842b2cd69b33e188 100644
--- a/src/ast.h
+++ b/src/ast.h
@@ -384,6 +384,8 @@ class Expression: public AstNode {
// TODO(rossberg): this should move to its own AST node eventually.
void RecordToBooleanTypeFeedback(TypeFeedbackOracle* oracle);
+ void RecordToBooleanTypeFeedback(
+ TypeFeedbackOracle* oracle, TypeFeedbackId origin);
Jakob Kummerow 2013/06/24 09:25:07 nit: one line per argument
byte to_boolean_types() const { return to_boolean_types_; }
BailoutId id() const { return id_; }
@@ -393,12 +395,14 @@ class Expression: public AstNode {
explicit Expression(Isolate* isolate)
: upper_type_(Type::Any(), isolate),
lower_type_(Type::None(), isolate),
+ to_boolean_types_(0),
id_(GetNextId(isolate)),
- test_id_(GetNextId(isolate)) {}
+ test_id_(GetNextId(isolate)) { }
private:
Handle<Type> upper_type_;
Handle<Type> lower_type_;
+
rossberg 2013/06/24 08:54:16 Nit: I'd remove that empty line
byte to_boolean_types_;
const BailoutId id_;
« no previous file with comments | « src/arm/lithium-codegen-arm.cc ('k') | src/ast.cc » ('j') | src/ast.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698