Fix to_boolean type feedback for unary and binary ops

src/ast.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 366 matching lines @@
     ASSERT(types != NULL && types->length() == 1);
     return types->at(0);
   }
   virtual KeyedAccessStoreMode GetStoreMode() {
     UNREACHABLE();
     return STANDARD_STORE;
   }
 
   // TODO(rossberg): this should move to its own AST node eventually.
   void RecordToBooleanTypeFeedback(TypeFeedbackOracle* oracle);
+  void RecordToBooleanTypeFeedback(
+      TypeFeedbackOracle* oracle, TypeFeedbackId origin);

[Jakob Kummerow, 2013/06/24 09:25:07]

nit: one line per argument

   byte to_boolean_types() const { return to_boolean_types_; }
 
   BailoutId id() const { return id_; }
   TypeFeedbackId test_id() const { return test_id_; }
 
  protected:
   explicit Expression(Isolate* isolate)
       : upper_type_(Type::Any(), isolate),
         lower_type_(Type::None(), isolate),
+        to_boolean_types_(0),
         id_(GetNextId(isolate)),
-        test_id_(GetNextId(isolate)) {}
+        test_id_(GetNextId(isolate)) { }
 
  private:
   Handle<Type> upper_type_;
   Handle<Type> lower_type_;
+

[rossberg, 2013/06/24 08:54:16]

Nit: I'd remove that empty line

   byte to_boolean_types_;
 
   const BailoutId id_;
   const TypeFeedbackId test_id_;
 };
 
 
 class BreakableStatement: public Statement {
  public:
   enum BreakableType {
@@ skipping 2796 matching lines @@
  private:
   Isolate* isolate_;
   Zone* zone_;
   Visitor visitor_;
 };
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_AST_H_