Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1744253002: [Smart Lock, UI] Smart Lock should be a link in Auto Sign-in dialog. (Closed)

Created:
4 years, 9 months ago by melandory
Modified:
4 years, 9 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Smart Lock, UI] Smart Lock should be a link in Auto Sign-in dialog. BUG=590744 Committed: https://crrev.com/75a95112a42b28e59708fb2ec0383d2c7b726a06 Cr-Commit-Position: refs/heads/master@{#378218}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/password_manager/AutoSigninFirstRunDialog.java View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
melandory
PTAL, thanks!
4 years, 9 months ago (2016-02-29 15:40:36 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1744253002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1744253002/20001
4 years, 9 months ago (2016-02-29 15:40:59 UTC) #4
Bernhard Bauer
lgtm
4 years, 9 months ago (2016-02-29 15:57:14 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-02-29 16:34:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1744253002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1744253002/20001
4 years, 9 months ago (2016-02-29 16:38:49 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-02-29 16:43:21 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-02-29 16:44:31 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/75a95112a42b28e59708fb2ec0383d2c7b726a06
Cr-Commit-Position: refs/heads/master@{#378218}

Powered by Google App Engine
This is Rietveld 408576698