Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2909)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/password_manager/AutoSigninFirstRunDialog.java

Issue 1744253002: [Smart Lock, UI] Smart Lock should be a link in Auto Sign-in dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/password_manager/AutoSigninFirstRunDialog.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/password_manager/AutoSigninFirstRunDialog.java b/chrome/android/java/src/org/chromium/chrome/browser/password_manager/AutoSigninFirstRunDialog.java
index 0337cb9a777413915c346818e849f63e3cb9125e..b6357413536ee51c53ab3bbb78e18d93939a1065 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/password_manager/AutoSigninFirstRunDialog.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/password_manager/AutoSigninFirstRunDialog.java
@@ -78,15 +78,17 @@ public class AutoSigninFirstRunDialog
R.layout.single_line_bottom_text_dialog, null);
TextView summaryView = (TextView) view.findViewById(R.id.summary);
- if (mExplanationLinkStart != 0 && mExplanationLinkEnd != 0) {
+ if (mExplanationLinkStart != mExplanationLinkEnd && mExplanationLinkEnd != 0) {
SpannableString spanableExplanation = new SpannableString(mExplanation);
spanableExplanation.setSpan(new ClickableSpan() {
@Override
public void onClick(View view) {
nativeOnLinkClicked(mNativeAutoSigninFirstRunDialog);
+ mDialog.dismiss();
}
}, mExplanationLinkStart, mExplanationLinkEnd, Spanned.SPAN_INCLUSIVE_INCLUSIVE);
summaryView.setText(spanableExplanation);
+ summaryView.setMovementMethod(LinkMovementMethod.getInstance());
} else {
summaryView.setText(mExplanation);
summaryView.setMovementMethod(LinkMovementMethod.getInstance());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698