Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1744243002: Remove internal calls to SkImage::getTexture (Closed)

Created:
4 years, 9 months ago by bsalomon
Modified:
4 years, 9 months ago
Reviewers:
robertphillips, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@budalias
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add getTexture() back to SkImage :( #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -39 lines) Patch
M gm/drawbitmaprect.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M gm/image_pict.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gyp/SampleApp.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/bench.gyp View 1 chunk +3 lines, -0 lines 0 comments Download
M gyp/visualbench.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkImage.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkPictureImageGenerator.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M src/core/SkSpecialImage.cpp View 6 chunks +11 lines, -10 lines 0 comments Download
M src/image/SkImage.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/image/SkImage_Base.h View 1 chunk +1 line, -1 line 0 comments Download
M src/image/SkImage_Gpu.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/image/SkImage_Gpu.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/image/SkSurface_Gpu.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/SurfaceTest.cpp View 4 chunks +12 lines, -14 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
bsalomon
I thought I could get rid of this API, but it turns out there are ...
4 years, 9 months ago (2016-02-29 17:31:37 UTC) #5
reed1
lgtm
4 years, 9 months ago (2016-02-29 17:55:16 UTC) #6
robertphillips
lgtm
4 years, 9 months ago (2016-02-29 19:27:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1744243002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1744243002/20001
4 years, 9 months ago (2016-02-29 19:28:06 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-02-29 19:41:57 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/84a4e5a8d683bf17d6c3058b977b9dfb000428af

Powered by Google App Engine
This is Rietveld 408576698