Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(791)

Issue 1744163002: [stubs] Introduce a proper ToBooleanStub. (Closed)

Created:
4 years, 9 months ago by Benedikt Meurer
Modified:
4 years, 9 months ago
CC:
Hannes Payer (out of office), oth, Paweł Hajdan Jr., rmcilroy, ulan, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Introduce a proper ToBooleanStub. Rename the existing (patching) ToBooleanStub to ToBooleanICStub to match our naming convention, and add a new TurboFan-powered ToBooleanStub, which just does the ToBoolean conversion without any runtime call or code patching, so we can use it for Ignition (and TurboFan). Drive-by-fix: Add an Oddball::to_boolean field similar to the ones we already have for to_string and to_number, so we don't need to actually dispatch on the concrete Oddball at all. R=epertoso@chromium.org, rmcilroy@chromium.org, yangguo@chromium.org Committed: https://crrev.com/d1df58e8d734ceb7d475b9c83263466f6ccd9031 Cr-Commit-Position: refs/heads/master@{#34361}

Patch Set 1 #

Patch Set 2 : Fix mips #

Unified diffs Side-by-side diffs Delta from patch set Stats (+476 lines, -364 lines) Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/code-factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/code-stubs.h View 6 chunks +19 lines, -13 lines 0 comments Download
M src/code-stubs.cc View 5 chunks +158 lines, -25 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 2 chunks +3 lines, -8 lines 0 comments Download
M src/compiler/code-stub-assembler.h View 3 chunks +6 lines, -1 line 0 comments Download
M src/compiler/code-stub-assembler.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/linkage.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 1 chunk +20 lines, -16 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 1 chunk +20 lines, -16 lines 0 comments Download
M src/compiler/type-hint-analyzer.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/crankshaft/arm/lithium-arm.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 3 chunks +12 lines, -11 lines 0 comments Download
M src/crankshaft/arm64/lithium-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 4 chunks +12 lines, -11 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.h View 2 chunks +7 lines, -10 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M src/crankshaft/hydrogen-osr.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 4 chunks +12 lines, -11 lines 0 comments Download
M src/crankshaft/ia32/lithium-ia32.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 4 chunks +12 lines, -11 lines 0 comments Download
M src/crankshaft/mips/lithium-mips.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 4 chunks +12 lines, -11 lines 0 comments Download
M src/crankshaft/mips64/lithium-mips64.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 3 chunks +12 lines, -11 lines 0 comments Download
M src/crankshaft/ppc/lithium-ppc.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 4 chunks +12 lines, -11 lines 0 comments Download
M src/crankshaft/x64/lithium-x64.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.cc View 4 chunks +12 lines, -11 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/factory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/factory.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/heap.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/heap.cc View 2 chunks +38 lines, -18 lines 0 comments Download
M src/heap/heap-inl.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/ic/ic.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/interpreter/interpreter.cc View 5 chunks +31 lines, -9 lines 0 comments Download
M src/objects.h View 2 chunks +6 lines, -2 lines 0 comments Download
M src/objects.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/runtime/runtime-interpreter.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M src/type-info.h View 1 chunk +1 line, -1 line 0 comments Download
D test/unittests/runtime/runtime-interpreter-unittest.cc View 1 chunk +0 lines, -73 lines 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 18 (9 generated)
Benedikt Meurer
4 years, 9 months ago (2016-02-29 09:50:23 UTC) #1
Benedikt Meurer
Yang: Please review ToBooleanIC renaming, and heap/bootstrapper setup (Oddball changes). Enrico: Please review TurboFan/Ignition parts. ...
4 years, 9 months ago (2016-02-29 09:51:23 UTC) #2
ulan
heap part lgtm
4 years, 9 months ago (2016-02-29 09:59:54 UTC) #5
epertoso
lgtm LGTM for TF/Ignition.
4 years, 9 months ago (2016-02-29 10:13:52 UTC) #6
Camillo Bruni
changes to Oddball + rename LGTM
4 years, 9 months ago (2016-02-29 10:16:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1744163002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1744163002/20001
4 years, 9 months ago (2016-02-29 11:50:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1744163002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1744163002/20001
4 years, 9 months ago (2016-02-29 12:13:15 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-02-29 12:16:07 UTC) #16
commit-bot: I haz the power
4 years, 9 months ago (2016-02-29 12:17:37 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d1df58e8d734ceb7d475b9c83263466f6ccd9031
Cr-Commit-Position: refs/heads/master@{#34361}

Powered by Google App Engine
This is Rietveld 408576698