src/type-info.h - Issue 1744163002: [stubs] Introduce a proper ToBooleanStub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/type-info.h

Issue 1744163002: [stubs] Introduce a proper ToBooleanStub. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix mips Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/type-info.h

diff --git a/src/type-info.h b/src/type-info.h

index 13a7f88b66095266fa6320ae5165664bd878575d..c4b0928fc4820484102e0db5ad33322f674e9480 100644

--- a/src/type-info.h

+++ b/src/type-info.h

@@ -71,7 +71,7 @@ class TypeFeedbackOracle: public ZoneObject {

Handle<JSFunction> GetCallNewTarget(FeedbackVectorSlot slot);

Handle<AllocationSite> GetCallNewAllocationSite(FeedbackVectorSlot slot);

- // TODO(1571) We can't use ToBooleanStub::Types as the return value because

+ // TODO(1571) We can't use ToBooleanICStub::Types as the return value because

// of various cycles in our headers. Death to tons of implementations in

// headers!! :-P

uint16_t ToBooleanTypes(TypeFeedbackId id);