Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(824)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1743863002: Rename enums/functions that collide in chromium style in core/svg,xml (Closed)

Created:
4 years, 10 months ago by danakj
Modified:
4 years, 9 months ago
Reviewers:
haraken, pdr., esprehn
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-bindings_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chrishtr, chromium-reviews, danakj+watch_chromium.org, dcheng, dshwang, drott+blinkwatch_chromium.org, krit, Eric Willigers, f(malita), fs, gyuyoung2, jbroman, Justin Novosad, kinuko+watch, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, pdr+graphicswatchlist_chromium.org, piman, rjwright, rwlbuis, Stephen Chennney, shans, Nico, tyoshino+watch_chromium.org, vmpstr+blinkwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename enums/functions that collide in chromium style in core/svg,xml R=esprehn@chromium.org, pdr BUG=582312 Committed: https://crrev.com/2b35f33a002750dc7e04ba240ac57b8c79dd8166 Cr-Commit-Position: refs/heads/master@{#378268}

Patch Set 1 : get-names-10 #

Patch Set 2 : get-names-10: rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -64 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/custom/V8XMLHttpRequestCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAngle.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimateMotionElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimateTransformElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedTypeAnimator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimationElement.h View 5 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimationElement.cpp View 14 chunks +18 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGBoolean.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGEnumeration.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGLengthList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGNumberList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPath.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPointList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGRect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTransformList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/animation/SVGSMILElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/animation/SVGSMILElement.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/xml/XPathPath.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/xml/XPathResult.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/xml/XPathStep.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/xml/XPathStep.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/xml/XPathValue.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 34 (17 generated)
danakj
4 years, 10 months ago (2016-02-27 00:20:00 UTC) #1
danakj
SMILE!
4 years, 10 months ago (2016-02-27 00:20:06 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1743863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1743863002/1
4 years, 10 months ago (2016-02-27 00:27:51 UTC) #4
pdr.
(: (: LGTM :) :)
4 years, 10 months ago (2016-02-27 00:43:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1743863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1743863002/1
4 years, 10 months ago (2016-02-27 01:13:22 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/151089)
4 years, 10 months ago (2016-02-27 01:43:34 UTC) #10
haraken
LGTM
4 years, 10 months ago (2016-02-27 03:07:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1743863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1743863002/1
4 years, 9 months ago (2016-02-29 18:14:50 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/181359)
4 years, 9 months ago (2016-02-29 18:22:51 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1743863002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1743863002/20001
4 years, 9 months ago (2016-02-29 18:28:53 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/152594)
4 years, 9 months ago (2016-02-29 18:35:17 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1743863002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1743863002/20001
4 years, 9 months ago (2016-02-29 19:20:42 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1743863002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1743863002/20001
4 years, 9 months ago (2016-02-29 19:23:03 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/30834)
4 years, 9 months ago (2016-02-29 19:54:12 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1743863002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1743863002/20001
4 years, 9 months ago (2016-02-29 19:55:11 UTC) #31
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-02-29 21:03:28 UTC) #32
commit-bot: I haz the power
4 years, 9 months ago (2016-02-29 21:04:38 UTC) #34
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/2b35f33a002750dc7e04ba240ac57b8c79dd8166
Cr-Commit-Position: refs/heads/master@{#378268}

Powered by Google App Engine
This is Rietveld 408576698