Rename enums/functions that collide in chromium style in core/style/

Rename enums/functions that collide in chromium style in core/style/

R=esprehn@chromium.org, pdr
BUG=582312
Committed: https://crrev.com/02dda935229d062978dc75a80a22e0b7173e9168
Cr-Commit-Position: refs/heads/master@{#378266}

[danakj, 2016-02-26 23:36:39]

https://codereview.chromium.org/1743803002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/CSSProperties.in (right):

https://codereview.chromium.org/1743803002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/CSSProperties.in:293: text-decoration
use_handlers_for=CSSPropertyTextDecorationLine,
longhands=text-decoration-line;text-decoration-style;text-decoration-color,
type_name=TextDecoration
For most of the changes in this file, it was lying about the type_name (the
python assume EFooBar for foo-bar. It just didn't appear in generated code so it
got away with it. So mostly this is just making things more true.

The one here is the only weird one, where it uses the -line version for
everything, but setting the type_name there does the wrong thing. So, I put the
getter there instead explicitly.

The type_name here, then, is not needed, but seems strictly more correct, so I
left it since I'd typed it. Now I've typed 3 more paragraphs about it. Such is
life.

[pdr., 2016-02-26 23:50:00]

pdr@chromium.org changed reviewers:
+ timloh@chromium.org

[pdr., 2016-02-26 23:51:16]

I think this looks good but I'd like timloh to take a look as well.

+cc timloh, could you please review this too?

https://codereview.chromium.org/1743803002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/CSSProperties.in (right):

https://codereview.chromium.org/1743803002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/CSSProperties.in:295: text-decoration-line
runtime_flag=CSS3TextDecorations, name_for_methods=TextDecoration,
getter=getTextDecoration, converter=convertFlags<TextDecoration>
Why a getter instead of a type_name?

[danakj, 2016-02-26 23:52:21]

https://codereview.chromium.org/1743803002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/CSSProperties.in (right):

https://codereview.chromium.org/1743803002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/CSSProperties.in:295: text-decoration-line
runtime_flag=CSS3TextDecorations, name_for_methods=TextDecoration,
getter=getTextDecoration, converter=convertFlags<TextDecoration>
On 2016/02/26 23:51:16, pdr wrote:
> Why a getter instead of a type_name?

See comment above. Its because of use_handlers_for there. type_name here broke
-line-specific stuff somewhere.

[danakj, 2016-02-26 23:58:05]

https://codereview.chromium.org/1743803002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/CSSProperties.in (right):

https://codereview.chromium.org/1743803002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/CSSProperties.in:295: text-decoration-line
runtime_flag=CSS3TextDecorations, name_for_methods=TextDecoration,
getter=getTextDecoration, converter=convertFlags<TextDecoration>
On 2016/02/26 23:52:21, danakj wrote:
> On 2016/02/26 23:51:16, pdr wrote:
> > Why a getter instead of a type_name?
> 
> See comment above. Its because of use_handlers_for there. type_name here broke
> -line-specific stuff somewhere.

Well, I lied? I went to get you the specific error but it's working, so must
have been something else. Updated the CL.

[danakj, 2016-02-26 23:59:34]

https://codereview.chromium.org/1743803002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/CSSProperties.in (right):

https://codereview.chromium.org/1743803002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/CSSProperties.in:295: text-decoration-line
runtime_flag=CSS3TextDecorations, name_for_methods=TextDecoration,
type_name=TextDecoration, converter=convertFlags<TextDecoration>
OIC, if I remove the name_for_methods, then it breaks. I think I had done that
before.

[danakj, 2016-02-27 01:08:50]

danakj@chromium.org changed reviewers:
+ haraken@chromium.org

[danakj, 2016-02-27 01:08:51]

+haraken for modules/ also

[haraken, 2016-02-27 03:09:05]

LGTM

[haraken, 2016-02-27 03:09:13]

The CQ bit was checked by haraken@chromium.org

[haraken, 2016-02-27 03:09:20]

The CQ bit was unchecked by haraken@chromium.org

[Timothy Loh, 2016-02-29 00:10:16]

lgtm

[danakj, 2016-02-29 18:08:33]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2016-02-29 18:08:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1743803002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1743803002/40001

[commit-bot: I haz the power, 2016-02-29 18:19:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-29 18:19:41]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[danakj, 2016-02-29 18:21:44]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-02-29 18:22:18]

The CQ bit was unchecked by danakj@chromium.org

[commit-bot: I haz the power, 2016-02-29 18:22:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1743803002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1743803002/40001

[danakj, 2016-02-29 18:26:46]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-02-29 18:26:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/1743803002/#ps60001
(title: "get-names-9: rebase")

[commit-bot: I haz the power, 2016-02-29 18:26:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1743803002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1743803002/60001

[commit-bot: I haz the power, 2016-02-29 18:33:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-29 18:33:42]

Exceeded global retry quota

[danakj, 2016-02-29 19:20:34]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2016-02-29 19:21:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1743803002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1743803002/60001

[commit-bot: I haz the power, 2016-02-29 19:50:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-29 19:50:57]

Exceeded global retry quota

[danakj, 2016-02-29 20:47:35]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2016-02-29 20:48:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1743803002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1743803002/60001

[commit-bot: I haz the power, 2016-02-29 20:56:25]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-02-29 20:57:46]

Description was changed from

==========
Rename enums/functions that collide in chromium style in core/style/

R=esprehn@chromium.org, pdr
BUG=582312
==========

to

==========
Rename enums/functions that collide in chromium style in core/style/

R=esprehn@chromium.org, pdr
BUG=582312

Committed: https://crrev.com/02dda935229d062978dc75a80a22e0b7173e9168
Cr-Commit-Position: refs/heads/master@{#378266}
==========

[commit-bot: I haz the power, 2016-02-29 20:57:49]

Patchset 4 (id:??) landed as
https://crrev.com/02dda935229d062978dc75a80a22e0b7173e9168
Cr-Commit-Position: refs/heads/master@{#378266}