Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.h

Issue 1743803002: Rename enums/functions that collide in chromium style in core/style/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@get-names-8
Patch Set: get-names-9: rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutBox.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.h b/third_party/WebKit/Source/core/layout/LayoutBox.h
index 27db312ea75e154c1d2e8cb9eb82fa184af001a8..8f347d259b9eba887c8c4116496b848a8287be9b 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBox.h
+++ b/third_party/WebKit/Source/core/layout/LayoutBox.h
@@ -443,34 +443,34 @@ public:
void setMarginLeft(LayoutUnit margin) { m_marginBoxOutsets.setLeft(margin); }
void setMarginRight(LayoutUnit margin) { m_marginBoxOutsets.setRight(margin); }
- LayoutUnit marginLogicalLeft() const { return m_marginBoxOutsets.logicalLeft(style()->writingMode()); }
- LayoutUnit marginLogicalRight() const { return m_marginBoxOutsets.logicalRight(style()->writingMode()); }
+ LayoutUnit marginLogicalLeft() const { return m_marginBoxOutsets.logicalLeft(style()->getWritingMode()); }
+ LayoutUnit marginLogicalRight() const { return m_marginBoxOutsets.logicalRight(style()->getWritingMode()); }
- LayoutUnit marginBefore(const ComputedStyle* overrideStyle = nullptr) const final { return m_marginBoxOutsets.before((overrideStyle ? overrideStyle : style())->writingMode()); }
- LayoutUnit marginAfter(const ComputedStyle* overrideStyle = nullptr) const final { return m_marginBoxOutsets.after((overrideStyle ? overrideStyle : style())->writingMode()); }
+ LayoutUnit marginBefore(const ComputedStyle* overrideStyle = nullptr) const final { return m_marginBoxOutsets.before((overrideStyle ? overrideStyle : style())->getWritingMode()); }
+ LayoutUnit marginAfter(const ComputedStyle* overrideStyle = nullptr) const final { return m_marginBoxOutsets.after((overrideStyle ? overrideStyle : style())->getWritingMode()); }
LayoutUnit marginStart(const ComputedStyle* overrideStyle = nullptr) const final
{
const ComputedStyle* styleToUse = overrideStyle ? overrideStyle : style();
- return m_marginBoxOutsets.start(styleToUse->writingMode(), styleToUse->direction());
+ return m_marginBoxOutsets.start(styleToUse->getWritingMode(), styleToUse->direction());
}
LayoutUnit marginEnd(const ComputedStyle* overrideStyle = nullptr) const final
{
const ComputedStyle* styleToUse = overrideStyle ? overrideStyle : style();
- return m_marginBoxOutsets.end(styleToUse->writingMode(), styleToUse->direction());
+ return m_marginBoxOutsets.end(styleToUse->getWritingMode(), styleToUse->direction());
}
- LayoutUnit marginOver() const final { return m_marginBoxOutsets.over(style()->writingMode()); }
- LayoutUnit marginUnder() const final { return m_marginBoxOutsets.under(style()->writingMode()); }
- void setMarginBefore(LayoutUnit value, const ComputedStyle* overrideStyle = nullptr) { m_marginBoxOutsets.setBefore((overrideStyle ? overrideStyle : style())->writingMode(), value); }
- void setMarginAfter(LayoutUnit value, const ComputedStyle* overrideStyle = nullptr) { m_marginBoxOutsets.setAfter((overrideStyle ? overrideStyle : style())->writingMode(), value); }
+ LayoutUnit marginOver() const final { return m_marginBoxOutsets.over(style()->getWritingMode()); }
+ LayoutUnit marginUnder() const final { return m_marginBoxOutsets.under(style()->getWritingMode()); }
+ void setMarginBefore(LayoutUnit value, const ComputedStyle* overrideStyle = nullptr) { m_marginBoxOutsets.setBefore((overrideStyle ? overrideStyle : style())->getWritingMode(), value); }
+ void setMarginAfter(LayoutUnit value, const ComputedStyle* overrideStyle = nullptr) { m_marginBoxOutsets.setAfter((overrideStyle ? overrideStyle : style())->getWritingMode(), value); }
void setMarginStart(LayoutUnit value, const ComputedStyle* overrideStyle = nullptr)
{
const ComputedStyle* styleToUse = overrideStyle ? overrideStyle : style();
- m_marginBoxOutsets.setStart(styleToUse->writingMode(), styleToUse->direction(), value);
+ m_marginBoxOutsets.setStart(styleToUse->getWritingMode(), styleToUse->direction(), value);
}
void setMarginEnd(LayoutUnit value, const ComputedStyle* overrideStyle = nullptr)
{
const ComputedStyle* styleToUse = overrideStyle ? overrideStyle : style();
- m_marginBoxOutsets.setEnd(styleToUse->writingMode(), styleToUse->direction(), value);
+ m_marginBoxOutsets.setEnd(styleToUse->getWritingMode(), styleToUse->direction(), value);
}
// The following functions are used to implement collapsing margins.
@@ -753,7 +753,7 @@ public:
virtual void markForPaginationRelayoutIfNeeded(SubtreeLayoutScope&);
- bool isWritingModeRoot() const { return !parent() || parent()->style()->writingMode() != style()->writingMode(); }
+ bool isWritingModeRoot() const { return !parent() || parent()->style()->getWritingMode() != style()->getWritingMode(); }
bool isOrthogonalWritingModeRoot() const { return parent() && parent()->isHorizontalWritingMode() != isHorizontalWritingMode(); }
void markOrthogonalWritingModeRoot();
void unmarkOrthogonalWritingModeRoot();
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutBox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698