Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1654)

Unified Diff: content/test/weburl_loader_mock.h

Issue 1743783002: Use WeakPtr and do not use pointer equality in WebURLLoaderMockFactory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Loader_URLTestHelpers
Patch Set: Rebase. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/test/weburl_loader_mock.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/test/weburl_loader_mock.h
diff --git a/content/test/weburl_loader_mock.h b/content/test/weburl_loader_mock.h
index 81a8e187bd9aff0cc648f366b23ecf3b96080716..a95cd01595367e5e1de4ee367067af7da58f5cc2 100644
--- a/content/test/weburl_loader_mock.h
+++ b/content/test/weburl_loader_mock.h
@@ -52,10 +52,12 @@ class WebURLLoaderMock : public blink::WebURLLoader {
blink::WebURLLoaderClient* client) override;
void cancel() override;
void setDefersLoading(bool defer) override;
+ void setLoadingTaskRunner(blink::WebTaskRunner*) override;
- bool isDeferred() { return is_deferred_; }
+ bool is_deferred() { return is_deferred_; }
+ bool is_cancelled() { return !client_; }
- void setLoadingTaskRunner(blink::WebTaskRunner*) override;
+ base::WeakPtr<WebURLLoaderMock> GetWeakPtr();
private:
WebURLLoaderMockFactory* factory_;
« no previous file with comments | « no previous file | content/test/weburl_loader_mock.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698